Icons in low-end tab switcher are washed |
||||||||||||
Issue descriptionChrome Canary 66.0.3356.0, low-end Android device. Low-end tab switcher displays white icons, but their shape is different, which suggests that they are "real" icons, just extremely washed out. (Also note white line at the bottom - is it supposed to be there?)
,
Apr 3 2018
Does this happen on all phones? A particular low end phone? If you force a phone to use this UI, does it repro (chrome://flags#enable-accessibility-tab-switcher)?
,
Apr 12 2018
This doesn't repro by simply enabling the accessibility tab switcher. I am able to repro on my svelte device though. I'll take look today.
,
Apr 12 2018
This issue is restricted to non-modern which likely means we broke something simple.
,
Apr 12 2018
Hmm, I see it in Monochrome, on a low-end device.
,
Apr 12 2018
Turns out this does repro if you enable accessibility tab switcher. Modern needs to be disabled though.
,
Apr 12 2018
This issue was likely the result of: https://chromium-review.googlesource.com/c/chromium/src/+/922682
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07bb6c7f239b336ba96630c7270a766cac303349 commit 07bb6c7f239b336ba96630c7270a766cac303349 Author: Matthew Jones <mdjones@chromium.org> Date: Fri Apr 13 18:37:11 2018 Don't tint favicon bitmaps in accessibility tab switcher This patch fixes the tint applied to all icons in the accessibility tab switcher when modern is not enabled. If the icon is a bitmap (if it is an actual favicon from the site) it does not get tinted. Bug: 817914 Change-Id: Iae7baa6be32f15098d354c50b7f09f152859215e Reviewed-on: https://chromium-review.googlesource.com/1010827 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550695} [modify] https://crrev.com/07bb6c7f239b336ba96630c7270a766cac303349/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
,
Apr 13 2018
,
Apr 13 2018
,
Apr 13 2018
This bug requires manual review: We are only 3 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 13 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07bb6c7f239b336ba96630c7270a766cac303349 commit 07bb6c7f239b336ba96630c7270a766cac303349 Author: Matthew Jones <mdjones@chromium.org> Date: Fri Apr 13 18:37:11 2018 Don't tint favicon bitmaps in accessibility tab switcher This patch fixes the tint applied to all icons in the accessibility tab switcher when modern is not enabled. If the icon is a bitmap (if it is an actual favicon from the site) it does not get tinted. Bug: 817914 Change-Id: Iae7baa6be32f15098d354c50b7f09f152859215e Reviewed-on: https://chromium-review.googlesource.com/1010827 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550695} [modify] https://crrev.com/07bb6c7f239b336ba96630c7270a766cac303349/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
,
Apr 17 2018
,
Apr 17 2018
,
Apr 18 2018
Issue 833358 has been merged into this issue.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31fb3207bca5f094d85f63e8a6df29b16a060e02 commit 31fb3207bca5f094d85f63e8a6df29b16a060e02 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Apr 19 15:11:08 2018 Don't tint favicon bitmaps in accessibility tab switcher This patch fixes the tint applied to all icons in the accessibility tab switcher when modern is not enabled. If the icon is a bitmap (if it is an actual favicon from the site) it does not get tinted. TBR=mdjones@chromium.org (cherry picked from commit 07bb6c7f239b336ba96630c7270a766cac303349) Bug: 817914 Change-Id: Iae7baa6be32f15098d354c50b7f09f152859215e Reviewed-on: https://chromium-review.googlesource.com/1010827 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550695} Reviewed-on: https://chromium-review.googlesource.com/1019601 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#125} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/31fb3207bca5f094d85f63e8a6df29b16a060e02/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
,
Apr 19 2018
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by dskiba@chromium.org
, Apr 3 2018