New issue
Advanced search Search tips

Issue 817903 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 806965
issue 831416


Participants' hotlists:
media-router-fixit


Sign in to add a comment

[Presentation API] Move public *.mojom and traits to WebKit/public/mojom

Project Member Reported by mfo...@chromium.org, Mar 1 2018

Issue description

Per https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMWgRNYpasVBpf06etsjoxFtvjxuYELvzCyCwZF-kssvRSH0gQ we should relocate our public mojom files (exposed outside Blink) to the new location.

Bug 806965 has details.
 

Comment 1 by mfo...@chromium.org, Apr 10 2018

Blockedon: 831416
Status: Started (was: Untriaged)
To make this service part of the public Blink API (and in so doing clean up a bunch of redundant code upstream), we should remove typemaps where possible.

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67461c8668abbbf19ff7a3b3592eaf16970578a6

commit 67461c8668abbbf19ff7a3b3592eaf16970578a6
Author: mark a. foltz <mfoltz@chromium.org>
Date: Fri Apr 13 17:05:41 2018

[Presentation API] Remove content::PresentationConnectionCloseReason.

We'd like to remove redundant enums from content/ and chrome/ related
to the Presentation API, and the associated typemapping code.

Eventually we will eliminate all the Presentation API typemaps from content/.

This change eliminates one enum from content, others will follow.

Bug:  817903 
Change-Id: I944f114886bee6a10348f33a4355262f3feb5901
Reviewed-on: https://chromium-review.googlesource.com/1003772
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550659}
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/android/router/media_router_android_unittest.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/media_router_base.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/media_router_base.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/media_router_base_unittest.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/test/mock_mojo_media_router.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/common/media_router/mojo/media_router.mojom
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/common/media_router/mojo/media_router.typemap
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/common/media_router/mojo/media_router_struct_traits.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/content/common/presentation/presentation.typemap
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/content/common/presentation/presentation_struct_traits.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/content/public/common/presentation_info.h

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9d2a451b27f99e8a408dd04a693e0936a13af6f

commit d9d2a451b27f99e8a408dd04a693e0936a13af6f
Author: mark a. foltz <mfoltz@chromium.org>
Date: Mon Apr 16 20:42:45 2018

[Presentation API] Remove content::PresentationError and PresesentationErrorType

This continues the cleanup of the Presentation API typemaps by removing two more
content:: types and replacing them with blink::mojo types defined in
presentation.mojom.

Some refactoring of code and tests was required as Mojo callbacks converted from
base::Optional to blink::mojom::PresentationErrorPtr, which is move-only.


Bug:  817903 
Change-Id: I46136114a4afa4c14d989f2fbac341ccffe56740
Reviewed-on: https://chromium-review.googlesource.com/1012984
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551103}
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/router/media_router_dialog_controller.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/router/media_router_dialog_controller.h
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/router/presentation/presentation_service_delegate_impl.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/ui/webui/media_router/media_router_dialog_controller_webui_impl_unittest.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/common/presentation/presentation.typemap
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/common/presentation/presentation_struct_traits.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/common/presentation/presentation_struct_traits.h
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/public/common/presentation_info.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/public/common/presentation_info.h

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67461c8668abbbf19ff7a3b3592eaf16970578a6

commit 67461c8668abbbf19ff7a3b3592eaf16970578a6
Author: mark a. foltz <mfoltz@chromium.org>
Date: Fri Apr 13 17:05:41 2018

[Presentation API] Remove content::PresentationConnectionCloseReason.

We'd like to remove redundant enums from content/ and chrome/ related
to the Presentation API, and the associated typemapping code.

Eventually we will eliminate all the Presentation API typemaps from content/.

This change eliminates one enum from content, others will follow.

Bug:  817903 
Change-Id: I944f114886bee6a10348f33a4355262f3feb5901
Reviewed-on: https://chromium-review.googlesource.com/1003772
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550659}
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/android/router/media_router_android_unittest.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/media_router_base.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/media_router_base.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/media_router_base_unittest.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/browser/media/router/test/mock_mojo_media_router.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/common/media_router/mojo/media_router.mojom
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/common/media_router/mojo/media_router.typemap
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/chrome/common/media_router/mojo/media_router_struct_traits.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/content/common/presentation/presentation.typemap
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/content/common/presentation/presentation_struct_traits.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/67461c8668abbbf19ff7a3b3592eaf16970578a6/content/public/common/presentation_info.h

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9d2a451b27f99e8a408dd04a693e0936a13af6f

commit d9d2a451b27f99e8a408dd04a693e0936a13af6f
Author: mark a. foltz <mfoltz@chromium.org>
Date: Mon Apr 16 20:42:45 2018

[Presentation API] Remove content::PresentationError and PresesentationErrorType

This continues the cleanup of the Presentation API typemaps by removing two more
content:: types and replacing them with blink::mojo types defined in
presentation.mojom.

Some refactoring of code and tests was required as Mojo callbacks converted from
base::Optional to blink::mojom::PresentationErrorPtr, which is move-only.


Bug:  817903 
Change-Id: I46136114a4afa4c14d989f2fbac341ccffe56740
Reviewed-on: https://chromium-review.googlesource.com/1012984
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551103}
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/router/media_router_dialog_controller.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/router/media_router_dialog_controller.h
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/router/presentation/presentation_service_delegate_impl.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/ui/webui/media_router/media_router_dialog_controller_webui_impl_unittest.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/common/presentation/presentation.typemap
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/common/presentation/presentation_struct_traits.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/common/presentation/presentation_struct_traits.h
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/public/common/presentation_info.cc
[modify] https://crrev.com/d9d2a451b27f99e8a408dd04a693e0936a13af6f/content/public/common/presentation_info.h

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8ad32025f9f5ee7119855e55724ff2ba490e109

commit e8ad32025f9f5ee7119855e55724ff2ba490e109
Author: mark a. foltz <mfoltz@chromium.org>
Date: Mon Apr 23 22:50:23 2018

[Presentation API] Remove content::PresentationConnectionState.

Further replacement of a content:: enum with a blink::mojom enum for the
Presentation API.  No behavioral changes.

Bug:  817903 
Change-Id: I66fc39db2e8f1e2220aa293e81a77b61d1f69c03
Reviewed-on: https://chromium-review.googlesource.com/1015289
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552872}
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/android/router/media_router_android_unittest.cc
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/router/media_router_base.cc
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/router/media_router_base.h
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/router/media_router_base_unittest.cc
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.cc
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.h
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/router/presentation/browser_presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/router/test/mock_mojo_media_router.h
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/media/router/test/test_helper.h
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/browser/ui/media_router/presentation_receiver_window_controller_browsertest.cc
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/common/media_router/mojo/media_router.typemap
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/chrome/common/media_router/mojo/media_router_struct_traits.h
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/content/common/presentation/presentation.typemap
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/content/common/presentation/presentation_struct_traits.h
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/e8ad32025f9f5ee7119855e55724ff2ba490e109/content/public/common/presentation_info.h

Project Member

Comment 7 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2084383ca7947095b35567355f7e86abbd4bcda

commit e2084383ca7947095b35567355f7e86abbd4bcda
Author: mark a. foltz <mfoltz@chromium.org>
Date: Fri May 11 19:21:50 2018

[Presentation API] Remove content::PresentationInfo.

Replaces usages of content::PresentationInfo with blink::mojom::PresentationInfo.
There should be no change in behavior.

The presentation ID length check in the typemap is moved to PresentationServiceImpl.
Presentation IDs are always generated by the browser and a too-long ID is a bug.

Bug:  817903 
Change-Id: I6518abbab6d8b6f24925f1fb649a150b08221622
Reviewed-on: https://chromium-review.googlesource.com/1026987
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557973}
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/android/router/media_router_android_unittest.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/media_router_base_unittest.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/media_router_dialog_controller.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/media_router_dialog_controller.h
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.h
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/presentation/local_presentation_manager.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/presentation/local_presentation_manager.h
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/presentation/local_presentation_manager_unittest.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/presentation/presentation_service_delegate_impl.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/presentation/presentation_service_delegate_impl.h
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/media/router/presentation/receiver_presentation_service_delegate_impl.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/ui/media_router/presentation_receiver_window_controller_browsertest.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/ui/webui/media_router/media_router_dialog_controller_webui_impl_unittest.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/chrome/common/media_router/mojo/media_router.typemap
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/content/common/presentation/presentation.typemap
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/content/common/presentation/presentation_struct_traits.cc
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/content/common/presentation/presentation_struct_traits.h
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/e2084383ca7947095b35567355f7e86abbd4bcda/content/public/common/BUILD.gn
[delete] https://crrev.com/e09fad69e00d42d54ebcf6706c163f163672dbfd/content/public/common/presentation_info.cc
[delete] https://crrev.com/e09fad69e00d42d54ebcf6706c163f163672dbfd/content/public/common/presentation_info.h

Comment 8 by mfo...@chromium.org, Jun 26 2018

Blocking: 831416

Comment 9 by mfo...@chromium.org, Jun 26 2018

Blockedon: -831416
Owner: mfo...@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d65a0f7da5baf268fee93abd85f22842fc75f7c2

commit d65a0f7da5baf268fee93abd85f22842fc75f7c2
Author: mark a. foltz <mfoltz@chromium.org>
Date: Fri Jul 13 18:56:50 2018

[Media Router] Remove typemap for content::PresentationConnectionMessage

This change removes the typemap from media_router::mojom::RouteMessage to
content::PresentationConnectionMessage, in preparation for removing
content::PresentationConnectionMessage entirely in a subsequent change [*].

The Media Router now uses media_router::mojom::RouteMessagePtr to pass around
media route messages, which is move-only and required updating the API for
MediaRouterMojoImpl.  This in turn required updating many unit tests.

Eventually, RouteMessage, RouteMessageObserver, and
BrowserPresentationConnectionProxy will be removed when a
PresentationConnection can be passed directly through the Media Router.

* https://chromium-review.googlesource.com/c/chromium/src/+/1123175

Bug:  817903 
Change-Id: I1f33a86fa3ed2cd1c00e370ce432a095bf21d3bd
Reviewed-on: https://chromium-review.googlesource.com/1123649
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575003}
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.h
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/presentation/browser_presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/providers/common/buffered_message_sender.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/providers/common/buffered_message_sender.h
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/providers/dial/dial_internal_message_util.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/providers/dial/dial_internal_message_util.h
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/providers/dial/dial_internal_message_util_unittest.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/providers/dial/dial_media_route_provider.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/providers/dial/dial_media_route_provider.h
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/providers/dial/dial_media_route_provider_unittest.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/route_message_observer.h
[add] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/route_message_util.cc
[add] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/route_message_util.h
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/test/mock_mojo_media_router.h
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/test/test_helper.cc
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/browser/media/router/test/test_helper.h
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/common/media_router/mojo/media_router.typemap
[modify] https://crrev.com/d65a0f7da5baf268fee93abd85f22842fc75f7c2/chrome/common/media_router/mojo/media_router_struct_traits.h

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/756d07e6ffaab2d19b2a7fa478090727518ba3ab

commit 756d07e6ffaab2d19b2a7fa478090727518ba3ab
Author: mark a. foltz <mfoltz@chromium.org>
Date: Fri Jul 20 20:59:18 2018

[Presentation API] Remove content::PresentationConnectionMessage

This replaces usages of content::PresentationConnectionMessage with
blink::mojom::PresentationConnectionMessagePtr, and removes the
presentation.mojom typemap and traits which are no longer needed.

This is the last step before we can move presentation.mojom to
third_party/blink/public/mojom.

It also updates relevant unittests to mock methods with move
parameters directly, instead of using helper methods.

Bug:  817903 ,851567
Change-Id: Ifc50db81108f78089e7f19a7a394069bb2b82b37
Reviewed-on: https://chromium-review.googlesource.com/1123175
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576981}
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.cc
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.h
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/presentation/browser_presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/presentation/local_presentation_manager.h
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/route_message_util.cc
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/route_message_util.h
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/media/router/test/test_helper.h
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/chrome/browser/ui/media_router/presentation_receiver_window_controller_browsertest.cc
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/browser/presentation/OWNERS
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/common/BUILD.gn
[delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/common/presentation/OWNERS
[delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/common/presentation/presentation.typemap
[delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/common/presentation/presentation_struct_traits.cc
[delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/common/presentation/presentation_struct_traits.h
[delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/common/presentation/typemaps.gni
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/content/public/common/BUILD.gn
[delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/public/common/presentation_connection_message.cc
[delete] https://crrev.com/bdabd139c2f0e5d6d0c6372fee73c22d63f86f79/content/public/common/presentation_connection_message.h
[modify] https://crrev.com/756d07e6ffaab2d19b2a7fa478090727518ba3ab/mojo/public/tools/bindings/chromium_bindings_configuration.gni

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bbe59fc38611758711d597d8284f348d5442780

commit 6bbe59fc38611758711d597d8284f348d5442780
Author: mark a. foltz <mfoltz@chromium.org>
Date: Tue Jul 24 20:06:24 2018

[Presentation API] Move presentation.mojom to blink/public

This completes the work to make the Presentation API mojo service part of the
Blink public API.

Bug:  817903 
Change-Id: I9e9cdc4567bb906640eb0ba68375e023f77305dd
Reviewed-on: https://chromium-review.googlesource.com/1145782
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577654}
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/chrome/browser/media/router/media_router_base.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/chrome/browser/media/router/media_router_dialog_controller.cc
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/chrome/browser/media/router/media_router_dialog_controller.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/chrome/browser/media/router/presentation/local_presentation_manager.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/chrome/browser/media/router/presentation/presentation_media_sinks_observer.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/chrome/browser/media/router/providers/cast/cast_internal_message_util.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/chrome/browser/media/router/route_message_util.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/chrome/browser/media/router/test/test_helper.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/chrome/browser/ui/media_router/presentation_receiver_window_controller_browsertest.cc
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/content/browser/DEPS
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/content/common/DEPS
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/content/public/browser/presentation_screen_availability_listener.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/WebKit/LayoutTests/presentation/presentation-controller-close-connection.html
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/WebKit/LayoutTests/presentation/presentation-controller-connection-closed-by-receiver.html
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/WebKit/LayoutTests/presentation/presentation-controller-terminate-connection.html
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/WebKit/LayoutTests/presentation/presentation-onreceiverconnection.html
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/WebKit/LayoutTests/presentation/presentation-receiver-terminate-connection.html
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/WebKit/LayoutTests/presentation/presentation-reconnect.html
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/WebKit/LayoutTests/presentation/presentation-start-error.html
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/WebKit/LayoutTests/presentation/presentation-start.html
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/WebKit/LayoutTests/presentation/resources/presentation-receiver-close-connection.html
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/WebKit/LayoutTests/presentation/resources/presentation-receiver-postmessage.html
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/public/mojom/presentation/OWNERS
[rename] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/public/mojom/presentation/presentation.mojom
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/public/platform/modules/presentation/OWNERS
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/renderer/modules/presentation/mock_presentation_service.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/renderer/modules/presentation/presentation_availability_observer.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/renderer/modules/presentation/presentation_availability_state.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/renderer/modules/presentation/presentation_connection.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/renderer/modules/presentation/presentation_connection_callbacks.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/renderer/modules/presentation/presentation_controller.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/renderer/modules/presentation/presentation_error.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/renderer/modules/presentation/presentation_receiver.h
[modify] https://crrev.com/6bbe59fc38611758711d597d8284f348d5442780/third_party/blink/renderer/modules/remoteplayback/remote_playback.h

Status: Fixed (was: Started)
This can finally be closed out assuming the last patch sticks.  Roughly 700 lines of unnecessary code was removed from content/ and elsewhere as well as many redundant types that were clones of the declarations in the mojom.


Sign in to add a comment