[Downloads Home] Show thumbnails from OfflineContentProvider |
||||||
Issue descriptionPull the OfflineItemVisuals from the OfflineContentProvider and show the thumbnail in the DownloadItemView. This should probably be done in a few phases: 1. Basic support that just pulls the visuals each time we show the view (much like we reach out to the ThumbnailProvider for images). 2. We add some sort of smart caching layer to prevent us from having to hit the backend every time during scroll. (this should require a quick investigation of existing thumbnail/icon caches so we don't just blindly add another 10mb cache layer). 3. Add in some smarts for prefetching icons etc. based on scroll position/direction/etc.
,
Mar 1 2018
+xingliu@ as this might be a combination of both (caching vs. UI changes). Let's talk offline later today!
,
Mar 5 2018
This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label. All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 5 2018
Pls apply appropriate OSs label.
,
Mar 5 2018
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ae8395241f0ec16b431bffb4222917395420b04 commit 3ae8395241f0ec16b431bffb4222917395420b04 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Tue Mar 06 22:08:29 2018 Thumbnails : Fetch thumbnails from offline item backend for download home Added basic support to download home to be able to fetch thumbnails from the offline pages backend. It doesn't have any caching which will be added in future CLs. Bug: 817853 Change-Id: I2885f649fb240fa9a28328b6af83a7e49897b092 Reviewed-on: https://chromium-review.googlesource.com/946904 Reviewed-by: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#541213} [modify] https://crrev.com/3ae8395241f0ec16b431bffb4222917395420b04/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java [modify] https://crrev.com/3ae8395241f0ec16b431bffb4222917395420b04/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8248a7d67691588352b0cb7790b2d9c29c916188 commit 8248a7d67691588352b0cb7790b2d9c29c916188 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Wed Mar 28 22:19:52 2018 Thumbnails : Modification of ThumbnailProvider for offline items ThumbnailProviderImpl provides a front-end cache for the thumbnails which relies on ThumbnailDiskStorage and ThumbnailGenerator to generate and provide thumbnails. For offline items, thumbnails would be provided by the OfflineContentProvider directly which takes care thumbnail creation and storage. Modified the existing ThumbnailProviderImpl class to accommodate the caching for thumbnails provided from OfflineContentProvider. Design doc : https://docs.google.com/document/d/1bz1PH42dN0cPWOUWswAwBtA91x_a8jRPWGIvNpG9LhQ Bug: 817853 Change-Id: Id3d928d9c76297f453f4a25d440ce0d338141294 Reviewed-on: https://chromium-review.googlesource.com/967449 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#546620} [modify] https://crrev.com/8248a7d67691588352b0cb7790b2d9c29c916188/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java [modify] https://crrev.com/8248a7d67691588352b0cb7790b2d9c29c916188/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java [modify] https://crrev.com/8248a7d67691588352b0cb7790b2d9c29c916188/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailProvider.java [modify] https://crrev.com/8248a7d67691588352b0cb7790b2d9c29c916188/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailProviderImpl.java
,
May 9 2018
shaktisahu@ is this issue now fixed?
,
May 11 2018
ping!
,
May 11 2018
Yes this is fixed.
,
May 11 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.
,
May 11 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dtrainor@chromium.org
, Mar 1 2018