deprecating perf-id on the perf dashboard upload |
||||
Issue descriptionI wanted to start the discussion on what the perf-id is used for on the perf dashboard and how we can deprecate it on the infra side. Currently, this value is populated from this file and is hard coded: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py?q=perf-id+file:%5Ebuild/scripts/slave/recipe_modules/chromium_tests/+package:%5Echromium$&l=118 I propose that we instead re-use the buildername so when you look at the perf waterfall the name of the configuration is the same there as it is on the perf dashboard. I think this will clear up a lot of confusion. What will this mean on the perf dashboard side if for new configurations we start sending https://cs.chromium.org/chromium/src/tools/perf/core/results_dashboard.py?l=328 bot = buildername and deprecate perf-id. This means if you look at the flags here https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_One_Perf%2F1211%2F%2B%2Frecipes%2Fsteps%2Fblink_perf.bindings_Dashboard_Upload%2F0%2Fstdout it would be Android One Perf instead of android-one.
,
Mar 1 2018
Note that we're upgrading nearly all the perf configs over the course of 2018. So if we could do something like when adding a new config, do not use perf-id, we could deprecate without needing a migration.
,
Mar 1 2018
Right. The linux configuration will be the only one as of now remaining the same.
,
Apr 10 2018
If you rename the bots on the perf waterfall to match the perf id, that doesn't require a data migration, right?
,
Apr 10 2018
*Dave: we are refreshing our hardware, so for ones with new hardware, there is no need to keep graph continuity & we should just use the new naming convention which Emily proposed.
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Oct 23
Unassigning myself as I'm wrapping up. |
||||
►
Sign in to add a comment |
||||
Comment 1 by simonhatch@chromium.org
, Mar 1 2018