Issue metadata
Sign in to add a comment
|
net/ shouldn't load wlanapi.dll dynamically on Windows |
||||||||||||||||||||||
Issue descriptionI don't believe we're going to want the network service to be able to load libraries dynamically. One of the few instances if this is in net/base/network_interfaces_win.cc, which dynamically loads wlanapi.dll. It looks to me like all methods we call should be available on XP SP3 and later, and since we require Windows 7, I think we're safe just statically linking to the library now, so I don't think this will be a difficult change (Though we may have to add wlanapi.lib as a link-time dependency).
,
May 15 2018
this is related to windows sandboxing. ccing appropriate people.
,
May 15 2018
From the Windows sandbox perspective, it will be fine to load wlanapi.dll during warmup - before lockdown. If the DLL might actually be nonexistent on some Win Server configs, we may want to keep the dynamic load that it does now (before sandbox lockdown). However, the existing code doesn't seem to gracefully handle if the DLL file is missing. https://cs.chromium.org/chromium/src/net/base/network_interfaces_win.cc?q=network_interfaces_win&sq=package:chromium&dr=C&l=106 I'll let you folks decide how you want to handle the possibly missing system DLL (what happens on our server clients now??). Matt, let me know if you have any questions about warmup, etc. Note, I'm just about to land a finch switch (default off) to turn on the Windows sandbox for testing. Ref: crbug/841001
,
May 18 2018
this is related to sandboxing and does not block network services canary.
,
May 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmenke@chromium.org
, Mar 1 2018