Clicking gear in VR summons "not supported in VR" UI |
||||||||
Issue description- enter VR browsing - take phone out of headset - click gear We're currently showing the "This feature is not supported in VR" prompt rather than the menu. Have chatted with mthiesse@ offline and we likely need a whitelist of UI that we may in fact display monocularly. When viewing WebVR content, the result is that the gear does nothing (really, we are attempting to show the not supported UI, but it is hidden because we're showing the WebVR content instead).
,
Mar 6 2018
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a85e1e692ee416d552f10f07062b92b6899348cf commit a85e1e692ee416d552f10f07062b92b6899348cf Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Mar 08 17:34:37 2018 VR: Fix Settings and Close button behaviour This fixes the close button behaviour under Deep-Linked apps to exit VR before launching a 2D Activity. Also fixes the Settings button to do the same, and exits to DD home when the Settings Activity is closed. Also drive-by fixes a bunch of StrictMode service leaks from DaydreamApi usage that doesn't close the DaydreamApi instance. Bug: 817811 Change-Id: I93b4544bf9bcfe08de690f466ff4a92d1fe69721 Reviewed-on: https://chromium-review.googlesource.com/953763 Reviewed-by: Yash Malik <ymalik@chromium.org> Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#541824} [modify] https://crrev.com/a85e1e692ee416d552f10f07062b92b6899348cf/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java [modify] https://crrev.com/a85e1e692ee416d552f10f07062b92b6899348cf/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java [modify] https://crrev.com/a85e1e692ee416d552f10f07062b92b6899348cf/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrFirstRunActivity.java [modify] https://crrev.com/a85e1e692ee416d552f10f07062b92b6899348cf/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/a85e1e692ee416d552f10f07062b92b6899348cf/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/a85e1e692ee416d552f10f07062b92b6899348cf/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/mock/MockVrDaydreamApi.java [modify] https://crrev.com/a85e1e692ee416d552f10f07062b92b6899348cf/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java [modify] https://crrev.com/a85e1e692ee416d552f10f07062b92b6899348cf/third_party/gvr-android-sdk/BUILD.gn
,
Mar 9 2018
booo, looks like this fix doesn't work with the O2 rendering path on, as it seems to ignore our settings button handler override?
,
Mar 9 2018
False alarm, I was using an old build without the fix.
,
Mar 9 2018
Not sure if this is relevant to this bug, but swiping in from the side and pressing the back system button also doesn't work.
,
Mar 9 2018
I also should mention that comment #6 only occurs on a DLA webvr presentation. which is Issue 817477 , duped to this bug.
,
Mar 9 2018
Yep, it's all the same underlying issue. I've addressed both bugs with my patch.
,
Mar 12 2018
Has the fix been verified on M67? Please note that this is marked as an M66 Beta blocker, so it'll need to be merged ASAP to make it in this week's release.
,
Mar 12 2018
Just verified the fix in Canary.
,
Mar 12 2018
,
Mar 12 2018
Please merge this as soon as possible so we can cut the beta build today.
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c206dff4a755a8397e65e77d6c4dc9e2b7e6400 commit 3c206dff4a755a8397e65e77d6c4dc9e2b7e6400 Author: Michael Thiessen <mthiesse@chromium.org> Date: Tue Mar 13 14:26:52 2018 VR: Fix Settings and Close button behaviour This fixes the close button behaviour under Deep-Linked apps to exit VR before launching a 2D Activity. Also fixes the Settings button to do the same, and exits to DD home when the Settings Activity is closed. Also drive-by fixes a bunch of StrictMode service leaks from DaydreamApi usage that doesn't close the DaydreamApi instance. TBR=mthiesse@chromium.org (cherry picked from commit a85e1e692ee416d552f10f07062b92b6899348cf) Bug: 817811 Change-Id: I93b4544bf9bcfe08de690f466ff4a92d1fe69721 Reviewed-on: https://chromium-review.googlesource.com/953763 Reviewed-by: Yash Malik <ymalik@chromium.org> Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541824} Reviewed-on: https://chromium-review.googlesource.com/960561 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#193} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/3c206dff4a755a8397e65e77d6c4dc9e2b7e6400/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java [modify] https://crrev.com/3c206dff4a755a8397e65e77d6c4dc9e2b7e6400/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java [modify] https://crrev.com/3c206dff4a755a8397e65e77d6c4dc9e2b7e6400/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrFirstRunActivity.java [modify] https://crrev.com/3c206dff4a755a8397e65e77d6c4dc9e2b7e6400/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/3c206dff4a755a8397e65e77d6c4dc9e2b7e6400/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/3c206dff4a755a8397e65e77d6c4dc9e2b7e6400/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/mock/MockVrDaydreamApi.java [modify] https://crrev.com/3c206dff4a755a8397e65e77d6c4dc9e2b7e6400/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java [modify] https://crrev.com/3c206dff4a755a8397e65e77d6c4dc9e2b7e6400/third_party/gvr-android-sdk/BUILD.gn
,
Mar 13 2018
,
Mar 14 2018
Verified on builds 66.0.3359.30 and 67.0.3370.0 Looks good.
,
Jul 4
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mthiesse@chromium.org
, Mar 6 2018