Merge to M65: Reset pacing settings after exiting from screenshare |
||||||
Issue descriptionThis fixes unwanted behavior in WebRTC. If user switches between sending screenshare and camera feed, video will be delayed by 2 seconds in some cases. Original bug: https://bugs.chromium.org/p/chromium/issues/detail?id=816930 Landed in WebRTC: https://webrtc.googlesource.com/src/+/2cb26a6a84abd813b252eeab0fb2a81621b66525 Not landed in Chrome yet because M66 branching and there are no rolls of WebRTC to chrome. Tested locally with manually patching fix to the M65 branch head.
,
Mar 1 2018
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 1 2018
+Chrome TPM Impact: This bug causes severe video delay in potentially all video conferencing services (with screenshare functionality), including appear.in, jitsi, hangouts, etc. Testing: The fix was tested local build of branch-head/3325 with the patch applied. I confirmed that problem did not reproduce with the patch. I confirmed that several different video conferencing scenarios did not regress in appear.in and hangouts. Regression risks: None, The fix consists of restoring some configuration values to their defaults in the situation where it should've been done but wasn't. All video calls already start with these values by default, so there are no risks that new issues would arise from this patch. This is M65 regression, not reproducible in M64.
,
Mar 1 2018
Approving merge to M65 based on comment #3. Please merge ASAP. Thank you.
,
Mar 1 2018
Merged here: https://webrtc.googlesource.com/src/+/9f7e2a90da243288657e1802af85168e87daab01
,
Mar 1 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by holmer@chromium.org
, Mar 1 2018