New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817795 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Task
Q2



Sign in to add a comment

Generate PNG assets for the tools menu

Project Member Reported by rohitrao@chromium.org, Mar 1 2018

Issue description

We require assets for the Tools Menu feature.

Menu Icons (@1x, @2x, @3x):

(Are these icons the same size in the compact vs regular menus?  Do they have pressed states?)

toolsmenu_reload          - Reload This Page button
toolsmenu_newtab          - New Tab button
toolsmenu_newincognitotab - New Incognito Tab button
toolsmenu_readlater       - Read Later button
toolsmenu_findinpage      - Find in Page button
toolsmenu_requestdesktop  - Request Desktop Site button
toolsmenu_siteinfo        - Site Information button
toolsmenu_print           - Print button
toolsmenu_feedback        - Report an Issue button
toolsmenu_bookmarks       - Bookmarks button
toolsmenu_readinglist     - Reading List button
toolsmenu_recenttabs      - Recent Tabs button
toolsmenu_history         - History button
toolsmenu_settings        - Settings button

Colors/sizes:
- menu background color
- menu rounded corner radius
- menu item font size
- menu item text color
- reading list badge font size
- reading list badge color

Redlines:
- layout of items within the menu, including icons and reading list badge
- positioning/size of menu in
  - compact x regular
  - compact x compact
  - regular x regular

 

Comment 1 Deleted

Comment 2 Deleted

I also need the image for the "Stop loading this page" button.
The NextAction date has arrived: 2018-03-16
Assets available here: https://drive.google.com/open?id=16eo-Zbtj_zFrWOKjIx-Y62Za_BZypoIY&authuser=pschaffner@google.com

Color/Sizes:
- menu background color: see  issue 820154  (same for all bubbles)
- menu rounded corner radius: see  issue 820154  (same for all bubbles)
- menu item font: system 17 (dynamic)
- menu item text color: #1A73E8 -> [NSColor colorWithRed:0.101 green:0.45 blue:0.909 alpha:1]
- reading list badge font: system 11 semibold
- reading list badge font color: #1A73E8 -> [NSColor colorWithRed:0.101 green:0.45 blue:0.909 alpha:1]
- reading list badge background color: #1A73E8 @ 10% -> [NSColor colorWithRed:0.101 green:0.45 blue:0.909 alpha:0.1]

Redlines:
- cell height: 44pt (@base font size, single line); no truncation; multi-line possible
- cell icon: 28x28pt; vertically aligned in a single-line cell + firstBaseline of label
- cell icon/label layout: H: |-15-[icon]-11-[label]-{11-[badge]-}15-|; V: |-12-[label]-12-|
- cell separator: 1pt high; black @ 5%; V: |-12-[separator]-12-|; H: [cell]-10-[separator]-10-[cell]
- menu top/bottom margin: 7pt
- menu position:
  - H: center aligned with calling button; V: 
[calling button][menu]; 5pt left/right screen edge margin; 15pt top/bottom screen edge margin
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6

commit 8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Mar 30 14:15:22 2018

Add assets for the tools menu.

This CL adds the different assets used by the tools menu.

Bug:  817795 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id272d5890d8fcb6a6d2a6832a5d66e0ac43c69f5
Reviewed-on: https://chromium-review.googlesource.com/987772
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547155}
[modify] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/BUILD.gn
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_bookmarks.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_bookmarks.imageset/popup_menu_bookmarks.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_bookmarks.imageset/popup_menu_bookmarks@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_bookmarks.imageset/popup_menu_bookmarks@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_find_in_page.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_find_in_page.imageset/popup_menu_find_in_page.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_find_in_page.imageset/popup_menu_find_in_page@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_find_in_page.imageset/popup_menu_find_in_page@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_help.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_help.imageset/popup_menu_help.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_help.imageset/popup_menu_help@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_help.imageset/popup_menu_help@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_history.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_history.imageset/popup_menu_history.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_history.imageset/popup_menu_history@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_history.imageset/popup_menu_history@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_new_incognito_tab.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_new_incognito_tab.imageset/popup_menu_new_incognito_tab.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_new_incognito_tab.imageset/popup_menu_new_incognito_tab@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_new_incognito_tab.imageset/popup_menu_new_incognito_tab@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_new_tab.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_new_tab.imageset/popup_menu_new_tab.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_new_tab.imageset/popup_menu_new_tab@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_new_tab.imageset/popup_menu_new_tab@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_read_later.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_read_later.imageset/popup_menu_read_later.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_read_later.imageset/popup_menu_read_later@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_read_later.imageset/popup_menu_read_later@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reading_list.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reading_list.imageset/popup_menu_reading_list.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reading_list.imageset/popup_menu_reading_list@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reading_list.imageset/popup_menu_reading_list@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_recent_tabs.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_recent_tabs.imageset/popup_menu_recent_tabs.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_recent_tabs.imageset/popup_menu_recent_tabs@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_recent_tabs.imageset/popup_menu_recent_tabs@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reload.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reload.imageset/popup_menu_reload.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reload.imageset/popup_menu_reload@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reload.imageset/popup_menu_reload@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_report_an_issue.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_report_an_issue.imageset/popup_menu_report_an_issue.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_report_an_issue.imageset/popup_menu_report_an_issue@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_report_an_issue.imageset/popup_menu_report_an_issue@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_request_desktop_site.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_request_desktop_site.imageset/popup_menu_request_desktop_site.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_request_desktop_site.imageset/popup_menu_request_desktop_site@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_request_desktop_site.imageset/popup_menu_request_desktop_site@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_request_mobile_site.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_request_mobile_site.imageset/popup_menu_request_mobile_site.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_request_mobile_site.imageset/popup_menu_request_mobile_site@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_request_mobile_site.imageset/popup_menu_request_mobile_site@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_settings.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_settings.imageset/popup_menu_settings.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_settings.imageset/popup_menu_settings@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_settings.imageset/popup_menu_settings@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_site_information.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_site_information.imageset/popup_menu_site_information.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_site_information.imageset/popup_menu_site_information@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_site_information.imageset/popup_menu_site_information@3x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_stop.imageset/Contents.json
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_stop.imageset/popup_menu_stop.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_stop.imageset/popup_menu_stop@2x.png
[add] https://crrev.com/8d83eb5e43f18af5631ee7a92d2e38a6482fc1e6/ios/chrome/browser/ui/popup_menu/resources/popup_menu_stop.imageset/popup_menu_stop@3x.png

Labels: -Q1 Q2

Comment 8 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 9 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Proj-UIRefresh

Comment 11 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
Labels: -Type-Bug Type-Task
NextAction: 2018-04-25
Status: Fixed (was: Assigned)
Closing this bug as more specific bugs have been created for the remaining tasks.
The NextAction date has arrived: 2018-04-25
NextAction: ----

Sign in to add a comment