New issue
Advanced search Search tips

Issue 817791 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[iOS] Should PersonalDataManagerFactory override GetBrowserStateToUse()

Project Member Reported by blundell@chromium.org, Mar 1 2018

Issue description

sdefresne@ noticed the following issue on https://chromium-review.googlesource.com/c/chromium/src/+/939462/4:

"nit: since PersonalDataManagerFactory does not override GetBrowserStateToUse, [PersonalDataManager] will only be called with non off-the-record CBS, and [the bool that it takes in specifying whether the user is off-the-record] will always be false.

I think that if PersonalDataManager receive a boolean on whether a CBS/Profile is or isn't off-the-record, then it should be possible to initialise the service with an off-the-record CBS/Profile. Or the boolean should be removed."

Notably, in //chrome, PersonalDataManagerFactory *does* override GetBrowserContextToUse() to specify that the incognito Profile should be used when in incognito mode. Is it an error that the same isn't done in //ios/chrome?
 

Sign in to add a comment