On/Off indicator shown on Passwords button in Settings |
|||||
Issue descriptionChrome Version: 66.0.3357.0 OS: iOS What steps will reproduce the problem? (1) In Chrome, navigate to Settings What is the expected result? The Passwords button doesn't have a status indicator (On/Off). What happens instead? The Passwords button has a status indicator (On/Off). (see screenshot) The string of the button was recently changed from Save Passwords to Passwords, so the On/Off indicator doesn't fit anymore.
,
Mar 1 2018
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65daff511aa0ec3685d5714a40a6474cc0d8e45f commit 65daff511aa0ec3685d5714a40a6474cc0d8e45f Author: Ioana Pandele <ioanap@chromium.org> Date: Thu Mar 01 15:18:08 2018 Remove On/Off status indicator from the Passwords button in Settings Bug:817785 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id735d1bd561de497e351d0482fa0e21b3c874359 Reviewed-on: https://chromium-review.googlesource.com/943106 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#540158} [modify] https://crrev.com/65daff511aa0ec3685d5714a40a6474cc0d8e45f/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
,
Mar 1 2018
,
Mar 2 2018
,
Mar 6 2018
Verified on chrome canary version 67.0.3363.0 on iPad Pro with iOS 11.2.6 and iPhone 8 with iOS 11.2.6. ON/OFF switch is not present for Password. Verified as per the screen shot in comment #6. Looks good. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ioanap@chromium.org
, Mar 1 2018