Remove LoadingPredictor from customtabs/ and move WarmupManager#maybePreconnectUrlAndSubreouces() to the new predictor |
|||
Issue description$subject
,
Mar 1 2018
There is code in custom tabs for the prefetch experiment that should be removed, and at any rate WarmupManager should talk to the new predictor, otherwise a number of CCT things will silently stop working.
,
May 14 2018
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/843edef8401ecbc1048895d5e40d95d82a404db0 commit 843edef8401ecbc1048895d5e40d95d82a404db0 Author: Benoit Lize <lizeb@chromium.org> Date: Thu May 17 13:35:05 2018 customtabs: Remove obsolete LoadingPredictor from CustomTabs. The entry point to the preconnect predictor is in WarmupManager, that correctly handles both the current and new predictors. Initialization still needs to be triggered for CustomTabs, as it otherwise happens after the first page load, which is too late for mayLaunchUrl() to be effective. Bug: 817784 Change-Id: I8dd9a7d41a508954151f7700d2e3fffa9ceb0320 Reviewed-on: https://chromium-review.googlesource.com/1059127 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by: Alexandr Ilin <alexilin@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559509} [modify] https://crrev.com/843edef8401ecbc1048895d5e40d95d82a404db0/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java [modify] https://crrev.com/843edef8401ecbc1048895d5e40d95d82a404db0/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java [delete] https://crrev.com/31f8df48a7c5bcc8050c636ff0fa60b2bcecbf04/chrome/android/java/src/org/chromium/chrome/browser/customtabs/LoadingPredictor.java [modify] https://crrev.com/843edef8401ecbc1048895d5e40d95d82a404db0/chrome/android/java_sources.gni [modify] https://crrev.com/843edef8401ecbc1048895d5e40d95d82a404db0/chrome/browser/BUILD.gn [modify] https://crrev.com/843edef8401ecbc1048895d5e40d95d82a404db0/chrome/browser/android/warmup_manager.cc [delete] https://crrev.com/31f8df48a7c5bcc8050c636ff0fa60b2bcecbf04/chrome/browser/predictors/loading_predictor_android.cc
,
May 17 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by alexilin@chromium.org
, Mar 1 2018