New issue
Advanced search Search tips

Issue 817784 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove LoadingPredictor from customtabs/ and move WarmupManager#maybePreconnectUrlAndSubreouces() to the new predictor

Project Member Reported by lizeb@chromium.org, Mar 1 2018

Issue description

$subject
 
The new predictor still uses LoadingPredictor as an external interface, what do you want to change?

Comment 2 by lizeb@chromium.org, Mar 1 2018

There is code in custom tabs for the prefetch experiment that should be removed, and at any rate WarmupManager should talk to the new predictor, otherwise a number of CCT things will silently stop working.

Comment 3 by lizeb@chromium.org, May 14 2018

Labels: -Pri-3 M-68 Pri-2
Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/843edef8401ecbc1048895d5e40d95d82a404db0

commit 843edef8401ecbc1048895d5e40d95d82a404db0
Author: Benoit Lize <lizeb@chromium.org>
Date: Thu May 17 13:35:05 2018

customtabs: Remove obsolete LoadingPredictor from CustomTabs.

The entry point to the preconnect predictor is in WarmupManager, that
correctly handles both the current and new predictors.

Initialization still needs to be triggered for CustomTabs, as it otherwise
happens after the first page load, which is too late for mayLaunchUrl() to be
effective.

Bug:  817784 
Change-Id: I8dd9a7d41a508954151f7700d2e3fffa9ceb0320
Reviewed-on: https://chromium-review.googlesource.com/1059127
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559509}
[modify] https://crrev.com/843edef8401ecbc1048895d5e40d95d82a404db0/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java
[modify] https://crrev.com/843edef8401ecbc1048895d5e40d95d82a404db0/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[delete] https://crrev.com/31f8df48a7c5bcc8050c636ff0fa60b2bcecbf04/chrome/android/java/src/org/chromium/chrome/browser/customtabs/LoadingPredictor.java
[modify] https://crrev.com/843edef8401ecbc1048895d5e40d95d82a404db0/chrome/android/java_sources.gni
[modify] https://crrev.com/843edef8401ecbc1048895d5e40d95d82a404db0/chrome/browser/BUILD.gn
[modify] https://crrev.com/843edef8401ecbc1048895d5e40d95d82a404db0/chrome/browser/android/warmup_manager.cc
[delete] https://crrev.com/31f8df48a7c5bcc8050c636ff0fa60b2bcecbf04/chrome/browser/predictors/loading_predictor_android.cc

Comment 5 by lizeb@chromium.org, May 17 2018

Status: Fixed (was: Assigned)

Sign in to add a comment