This is causing a failure in the following test from WPT: http://w3c-test.org/css/css-text/line-break/line-break-normal-025.xht But this is working fine if you enable LayoutNG. JFYI, other browsers also fail to pass this test and show the same behavior than Chromium, only Firefox does it right for the dollar sign but not the other. Spec: http://www.w3.org/TR/css-text-3/#line-break
I'm just reporting it to link this bug from TestExpectations file. I understand that as it's working with LayoutNG we can close it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f75a2842405ed0f378d8a4e60d6de2568704880 commit 9f75a2842405ed0f378d8a4e60d6de2568704880 Author: Manuel Rego Casasnovas <rego@igalia.com> Date: Fri Mar 02 03:44:44 2018 [css-text] Link css-text WPT test suite failures to specific bugs These tests were imported in r539150, the failures have been analized and the bugs reported accordingly. This patch modifies TestExpectations to link to the specific issues for each test. BUG= 306730 , 817773 , 817776 , 817778 , 817781 , 817804 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ibfb975f825188d1693d6526fef489fd76da3ec21 Reviewed-on: https://chromium-review.googlesource.com/943104 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#540439} [modify] https://crrev.com/9f75a2842405ed0f378d8a4e60d6de2568704880/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/9f75a2842405ed0f378d8a4e60d6de2568704880/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba5fbe99e05c4a00715500277236e7ab092fd3e1 commit ba5fbe99e05c4a00715500277236e7ab092fd3e1 Author: Koji Ishii <kojii@chromium.org> Date: Wed Mar 14 11:17:28 2018 Review and cleanup wpt/css/css-text/ failures This patch reviewed failures of wpt/css/css-text, grouped and sorted, with following modifications: 1. Skip importing features with no active contributors. When we have plans or contributors, we can unskip them. 2. Following tests were removed because they are based on old versions of Unicode. According to the most recent spec at: https://www.unicode.org/Public/UNIDATA/extracted/DerivedLineBreak.txt css3-text-line-break-opclns-013 U+23B4 is AL, not CL css3-text-line-break-opclns-048 U+FD3E is CL, not OP css3-text-line-break-opclns-118 U+23B5 is AL, not CL css3-text-line-break-opclns-154 U+FD3F is OP, not CL css3-text-line-break-opclns-216 U+30FC is CJ, not NS css3-text-line-break-opclns-224 U+FF70 is CJ, not NS 3. Following tests were removed because they hard code pixel widths, and their cases are covered by other tests. word-break-normal-002 4. Following tests were removed because they are based on JLREQ, a W3C notes that explains traditional Japanese typography, but not defined in the CSS spec nor in Unicode spec. line-break-normal-025 line-break-strict-018a line-break-strict-018b Bug: 817781 , 817778 , 817776 Change-Id: I92b1abc99fa8019e5d514e485f6c4733075216ba Reviewed-on: https://chromium-review.googlesource.com/960683 Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#543049} [modify] https://crrev.com/ba5fbe99e05c4a00715500277236e7ab092fd3e1/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/ba5fbe99e05c4a00715500277236e7ab092fd3e1/third_party/WebKit/LayoutTests/W3CImportExpectations [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-opclns-013.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-opclns-048.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-opclns-118.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-opclns-154.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-opclns-216.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-opclns-224.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-opclns-013-ref.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-opclns-048-ref.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-opclns-118-ref.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-opclns-154-ref.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-opclns-216-ref.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-opclns-224-ref.html [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/line-break/line-break-normal-025.xht [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/line-break/line-break-strict-018a.xht [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/line-break/line-break-strict-018b.xht [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/line-break/reference/line-break-normal-025-ref.xht [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/line-break/reference/line-break-strict-018a-ref.xht [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/line-break/reference/line-break-strict-018b-ref.xht [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/word-break/reference/word-break-normal-002-ref.xht [delete] https://crrev.com/f8781418ce126ab08de6a82eef749d4c3bef5080/third_party/WebKit/LayoutTests/external/wpt/css/css-text/word-break/word-break-normal-002.xht
Comment 1 by r...@igalia.com
, Mar 1 2018