New issue
Advanced search Search tips

Issue 817773 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
kojii@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
layoutng


Sign in to add a comment

[css-text] Browser should allow some special characters at the beginning of a line

Project Member Reported by r...@igalia.com, Mar 1 2018 

This is causing that several tests from WPT suite are failing.
For example:
http://w3c-test.org/css/css-text/i18n/css3-text-line-break-jazh-136.html

BTW, it seems to be also failing if you enable LayoutNG.

JFYI, other browsers also fail to pass this test and show the same behavior than Chromium.

Spec: https://drafts.csswg.org/css-text-3/#line-break
Note: For more information about expected line break behavior and line break classes,
see Unicode Standard Annex #14 Line Breaking Properties (http://www.unicode.org/reports/tr14/).

List of failing tests:
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-136.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-137.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-142.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-143.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-150.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-151.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-356.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-357.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-360.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-361.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-368.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-369.html
*  external/wpt/css/css-text/i18n/css3-text-line-break-jazh-371.html

Comment 1 by r...@igalia.com, Mar 1 2018

Description: Show this description

Comment 2 by e...@chromium.org, Mar 1 2018

Status: Available (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f75a2842405ed0f378d8a4e60d6de2568704880

commit 9f75a2842405ed0f378d8a4e60d6de2568704880
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Fri Mar 02 03:44:44 2018

[css-text] Link css-text WPT test suite failures to specific bugs

These tests were imported in r539150, the failures have been analized
and the bugs reported accordingly.
This patch modifies TestExpectations to link to the specific issues
for each test.

BUG= 306730 , 817773 , 817776 , 817778 , 817781 , 817804 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ibfb975f825188d1693d6526fef489fd76da3ec21
Reviewed-on: https://chromium-review.googlesource.com/943104
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540439}
[modify] https://crrev.com/9f75a2842405ed0f378d8a4e60d6de2568704880/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/9f75a2842405ed0f378d8a4e60d6de2568704880/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bc1294791e55d5b7495b278cec6a8a4f59c74b3

commit 5bc1294791e55d5b7495b278cec6a8a4f59c74b3
Author: Koji Ishii <kojii@chromium.org>
Date: Mon Mar 05 18:01:34 2018

Remove tests of non-defined behaviors for `line-break: loose`

These tests test behavior for [line-break: loose] as described
in [JLREQ], a Note that describes traditional Japanese typography,
published by W3C i18n WG, but not in Unicode [UAX#14] Line
Breaking Algorithm nor in CSS Text Level 3 [line-break: loose].

They were considered and discussed in WG, but they do not fit well
with multi-lingual typography. Also because most traditional
Japanese typography used to use their fullwidth counterpart, the
values are limited, and that they did not make into the specs.

Gecko fails these tests too according to the test results:
http://test.csswg.org/harness/results/css-text-3_dev/grouped/

U+003A is `IS`
  css3-text-line-break-jazh-136.html
  css3-text-line-break-jazh-356.html
U+003B is `IS`
  css3-text-line-break-jazh-137.html
  css3-text-line-break-jazh-357.html
U+0021 is `EX`
  css3-text-line-break-jazh-142.html
  css3-text-line-break-jazh-360.html
U+003F is `EX`
  css3-text-line-break-jazh-143.html
  css3-text-line-break-jazh-361.html
U+0025 is `PO`
  css3-text-line-break-jazh-150.html
  css3-text-line-break-jazh-368.html
  css3-text-line-break-jazh-371.html
U+00A2 is `PO`
  css3-text-line-break-jazh-151.html
  css3-text-line-break-jazh-369.html

[JLREQ]: https://www.w3.org/TR/jlreq/
[UAX#14]: http://unicode.org/reports/tr14/
[line-break: loose]: https://drafts.csswg.org/css-text-3/#valdef-line-break-loose

Bug:  817773 
Change-Id: Iec38bffb0f74e82f5527313693b335ab8097d492
Reviewed-on: https://chromium-review.googlesource.com/948682
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540865}
[modify] https://crrev.com/5bc1294791e55d5b7495b278cec6a8a4f59c74b3/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-136.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-137.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-142.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-143.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-150.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-151.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-356.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-357.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-360.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-361.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-368.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-369.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/css3-text-line-break-jazh-371.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-136-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-137-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-142-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-143-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-150-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-151-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-356-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-357-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-360-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-361-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-368-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-369-ref.html
[delete] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/third_party/WebKit/LayoutTests/external/wpt/css/css-text/i18n/reference/css3-text-line-break-jazh-371-ref.html

Comment 5 by kojii@chromium.org, Mar 13 2018

Status: Fixed (was: Available)
►

Sign in to add a comment