New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817772 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Developer with tryjob access couldn't CQ+2 his own CL

Project Member Reported by machenb...@chromium.org, Mar 1 2018

Issue description

The user ilija.pavlovic@mips.com couldn't CQ+2 here:
https://chromium-review.googlesource.com/c/v8/v8/+/941212#message-85c852debf92f3b40df9e83945a57dca2f7d278f

The CL was originally uploaded by ilija.pavlovic.imgtec@gmail.com - maybe CQ was stuck on that? If that's the case, just wontfix this issue.

@ilija.pavlovic: Could you please try to upload a new dummy CL with lija.pavlovic@mips.com originally and then attempt CQ+1?
 
Ok - I will inform you when a CL is ready
FYI: ilija.pavlovic@mips.com is listed in auth group project-v8-tryjob-access
I tried with upload a CL but now I received following error message:


$ git cl upload
Running presubmit upload checks ...
No changes in files detected. Skipping cpplint check.
Total violating files: 0
Traceback (most recent call last):
  File "/home/rtrk/MIPS/depot_tools/git_cl.py", line 6174, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/rtrk/MIPS/depot_tools/git_cl.py", line 6156, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/home/rtrk/MIPS/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/home/rtrk/MIPS/depot_tools/git_cl.py", line 5006, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/home/rtrk/MIPS/depot_tools/git_cl.py", line 1593, in CMDUpload
    change=change)
  File "/home/rtrk/MIPS/depot_tools/git_cl.py", line 1527, in RunHook
    gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
  File "/home/rtrk/MIPS/depot_tools/presubmit_support.py", line 1419, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/home/rtrk/MIPS/depot_tools/presubmit_support.py", line 1326, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 428, in CheckChangeOnUpload
  File "<string>", line 297, in _CommonChecks
  File "<string>", line 96, in _V8PresubmitChecks
  File "/home/rtrk/MIPS/v8/tools/presubmit.py", line 187, in RunOnFiles
    return self.ProcessFiles(all_files)
  File "/home/rtrk/MIPS/v8/tools/presubmit.py", line 517, in ProcessFiles
    success &= _CheckStatusFileForDuplicateKeys(status_file_path)
  File "/home/rtrk/MIPS/v8/tools/presubmit.py", line 498, in _CheckStatusFileForDuplicateKeys
    json.loads(contents, object_pairs_hook=check_pairs)
  File "/usr/lib/python2.7/json/__init__.py", line 351, in loads
    return cls(encoding=encoding, **kw).decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
    obj, end = self.scan_once(s, idx)
ValueError: Expecting , delimiter: line 199 column 25 (char 9646)

please upload with
git cl upload --bypass-hooks
to avoid the local presubmit check for now
This is also interesting thing: - no meter if I am logged in as ilija.pavlovic@mips.com - it will always switch me to ilija.pavlovic.imgtec@gmail.com.

--------------------
$ depot-tools-auth login codereview.chromium.org
Your browser has been opened to visit:

    https://accounts.google.com/o/oauth2/auth?redirect_uri=http%3A%2F%2Flocalhost%3A8090%2F&response_type=code&client_id=446450136466-2hr92jrq8e6i4tnsa56b52vacp7t3936.apps.googleusercontent.com&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.email&approval_prompt=force&access_type=offline

If your browser is on a different machine then exit and re-run this application with the command-line parameter

  --auth-no-local-webserver

Logged in to codereview.chromium.org as ilija.pavlovic.imgtec@gmail.com.

To login with a different email run:
  depot-tools-auth login codereview.chromium.org
To logout and purge the authentication token run:
  depot-tools-auth logout codereview.chromium.org
--------------------------

codereview.chromium.org is deprecated. It's only important as what you log in to https://chromium-review.googlesource.com

This should be in your ~/.gitcookies file. Mine has this (except myinvention and 123):
chromium-review.googlesource.com	TRUE	/	TRUE	123	o	git-machenbach.chromium.org=myinvention
chromium.googlesource.com	TRUE	/	TRUE	123	o	git-machenbach.chromium.org=myinvention

You can get these lines when going to chromium.googlesource.com/new-password with the correct account.
https://chromium-review.googlesource.com/c/v8/v8/+/942886#message-2745c1ea5a7ece70fc9e61aa3919c992e27e17ae also denies CQ+1 as I can see. And it seems to use the right account.

Comment 9 Deleted

Cc: aga...@chromium.org
CC Aaron for the account question.

I deleted the last comment since you pasted a key. I suggest you hit the chromium.googlesource.com/new-password link again and maybe revoke the old ones...

Here your text with some modifications:

I am logged in with mips account, and I got again credentials for gmail account.

------------------
set +o history
touch ~/.gitcookies
chmod 0600 ~/.gitcookies

git config --global http.cookiefile ~/.gitcookies

tr , \\t <<\__END__ >>~/.gitcookies
chromium.googlesource.com,FALSE,/,TRUE,1234,o,git-ilija.pavlovic.imgtec.gmail.com=1myinvention
chromium-review.googlesource.com,FALSE,/,TRUE,1234,o,git-ilija.pavlovic.imgtec.gmail.com=myinvention
__END__
set -o history

------------------
Components: -Infra>Platform>CQ Infra>Codereview>Gerrit
This is purely because weird account situation on Gerrit.
I think that the problem is in following:
- Primary was created gmail account.
- Later, I added another e-mail account (mips e-mail) for signing in gmail account.

I created a new account with mips e-mail, and will see if this will solve this confusion.

New account and "Google CLA" agreement solved the problem.
Is there an actionable problem left here? Otherwise -> wontfix is likely.
For now, I can't see any problem.
Next time, when I upload a CL will see if happens something strange.
Till then, we can left this issue opened (if it is not a problem).
Otherwise, you can close the issue and if similar problem appears - you will be informed.
Status: Fixed (was: Untriaged)
We'll close this issue for now, feel free to re-open or comment on it again if this comes up again.

Sign in to add a comment