New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817769 link

Starred by 0 users
Status: Fixed
Owner:
█ c.pa...@samsung.com
Last visit > 30 days ago
Closed: Apr 2018
Cc:
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Implement InputDeviceInfo.getCapabilities()

Project Member Reported by c.pa...@samsung.com, Mar 1 2018 
This task is to introduce InputDeviceInfo interface and implement its getCapabilities() method that gives access to the capabilities of the input device it represents.
https://w3c.github.io/mediacapture-main/#dom-inputdeviceinfo-getcapabilities

InputDeviceInfo extends MediaDeviceInfo and represents audio and video input devices. These objects are the result of calling MediaDevices.enumerateDevices().

Comment 1 by c.pa...@samsung.com, Mar 1 2018

Description: Show this description

Comment 2 by guidou@chromium.org, Mar 1 2018

Labels: -Type-Task -Pri-3 Pri-2 Type-Feature

Comment 3 by c.pa...@samsung.com, Mar 1 2018

Labels: -Type-Feature Type-Task

Comment 4 by c.pa...@samsung.com, Mar 1 2018

Labels: -Type-Task Type-Feature
Sorry for the overwrite.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d90e1fbfc04dab4f39325fa2000e3fcf5ee29467

commit d90e1fbfc04dab4f39325fa2000e3fcf5ee29467
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Wed Mar 07 19:40:17 2018

Add typemapping for blink::mojom::FacingMode

This CL typemaps blink::mojom::FacingMode to media::VideoFacingMode.
This is required for adding a FacingMode field to MediaDeviceInfo mojom
struct when we support facingMode for InputDeviceInfo.getCapabilities().

Bug:  817769 
Change-Id: Idd4a8d80b2070a9add6b8d305b30f37c0a3565b1
Reviewed-on: https://chromium-review.googlesource.com/951672
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#541532}
[modify] https://crrev.com/d90e1fbfc04dab4f39325fa2000e3fcf5ee29467/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
[modify] https://crrev.com/d90e1fbfc04dab4f39325fa2000e3fcf5ee29467/content/common/media/media_devices.typemap
[modify] https://crrev.com/d90e1fbfc04dab4f39325fa2000e3fcf5ee29467/content/common/media/media_devices_typemap_traits.cc
[modify] https://crrev.com/d90e1fbfc04dab4f39325fa2000e3fcf5ee29467/content/common/media/media_devices_typemap_traits.h
[modify] https://crrev.com/d90e1fbfc04dab4f39325fa2000e3fcf5ee29467/content/renderer/media/stream/apply_constraints_processor.cc
[modify] https://crrev.com/d90e1fbfc04dab4f39325fa2000e3fcf5ee29467/content/renderer/media/stream/media_stream_constraints_util_video_device.cc
[modify] https://crrev.com/d90e1fbfc04dab4f39325fa2000e3fcf5ee29467/content/renderer/media/stream/media_stream_constraints_util_video_device_unittest.cc
[modify] https://crrev.com/d90e1fbfc04dab4f39325fa2000e3fcf5ee29467/content/renderer/media/stream/user_media_client_impl_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/636394fb5626827fd9c15e0a60df4ce9fe8af6f0

commit 636394fb5626827fd9c15e0a60df4ce9fe8af6f0
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Thu Mar 08 11:37:46 2018

Introduce InputDeviceInfo interface

InputDeviceInfo extends MediaDeviceInfo and represents audio and video input
devices. These objects are the result of calling MediaDevices.enumerateDevices().
This interface gives access to the capabilities of the input device it represents
via getCapabilities() method which will be implemented in asubsequent CL.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h4sCuIqb_78

Bug:  817769 
Change-Id: Ic9a016a05e622ee02b86d567f64c3ed84f0926c3
Reviewed-on: https://chromium-review.googlesource.com/942961
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541772}
[modify] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/LayoutTests/external/wpt/interfaces/mediacapture-main.idl
[modify] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-IDL-all-expected.txt
[modify] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt
[modify] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-IDL-enumerateDevices.html
[modify] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-enumerateDevices.https.html
[modify] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/Source/modules/mediastream/BUILD.gn
[add] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/Source/modules/mediastream/InputDeviceInfo.cpp
[add] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/Source/modules/mediastream/InputDeviceInfo.h
[add] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/Source/modules/mediastream/InputDeviceInfo.idl
[modify] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/Source/modules/mediastream/MediaDeviceInfo.h
[modify] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/636394fb5626827fd9c15e0a60df4ce9fe8af6f0/third_party/WebKit/Source/modules/modules_idl_files.gni
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ea508165c07cb74f6e632a117ce6f38c08bf18b

commit 2ea508165c07cb74f6e632a117ce6f38c08bf18b
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Fri Mar 16 11:24:18 2018

Implement InputDeviceInfo.getCapabilities() for video devices

Bug:  817769 
Change-Id: I3f06b5f2360c570ff8c5b4bd800ca1014cc7d088
Reviewed-on: https://chromium-review.googlesource.com/956383
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543664}
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/content/browser/renderer_host/media/media_devices_dispatcher_host.h
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/content/browser/renderer_host/media/media_devices_manager.cc
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/content/browser/renderer_host/media/media_devices_manager.h
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/content/renderer/media/stream/apply_constraints_processor.cc
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/content/renderer/media/stream/user_media_client_impl_unittest.cc
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/content/renderer/pepper/pepper_media_device_manager.cc
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/content/renderer/pepper/pepper_media_device_manager.h
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-enumerateDevices.https.html
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/third_party/WebKit/Source/modules/mediastream/InputDeviceInfo.cpp
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/third_party/WebKit/Source/modules/mediastream/InputDeviceInfo.h
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/third_party/WebKit/Source/modules/mediastream/MediaDevices.h
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/third_party/WebKit/Source/modules/mediastream/MediaDevicesTest.cpp
[modify] https://crrev.com/2ea508165c07cb74f6e632a117ce6f38c08bf18b/third_party/WebKit/public/platform/modules/mediastream/media_devices.mojom

Comment 9 by c.pa...@samsung.com, Mar 20 2018 

guidou@: With InputDeviceInfo.getCapabilities() done, I would like to continue with my contributions. Please let me know if there's anything interesting that I can take up next. Thanks.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8e3038773096180acd585551a4b3129f89ec7b6

commit f8e3038773096180acd585551a4b3129f89ec7b6
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Mon Mar 26 07:45:23 2018

Rectify comments in media_devices.mojom

This CL is a follow-up on https://crrev.com/c/956383.

Bug:  817769 
Change-Id: I83a87fc0ee5889e9efa2c6e7a86ae8f2c6c70b90
Reviewed-on: https://chromium-review.googlesource.com/978225
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#545731}
[modify] https://crrev.com/f8e3038773096180acd585551a4b3129f89ec7b6/third_party/WebKit/public/platform/modules/mediastream/media_devices.mojom
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6520f685d3ec41fcd4bafec8fd7b3038920d5186

commit 6520f685d3ec41fcd4bafec8fd7b3038920d5186
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Mon Mar 26 09:59:00 2018

Add support for autoGainControl and noiseSuppression to getCapabilities()

This CL adds support for autoGainControl and noiseSuppression properties
to MediaStreamTrack.getCapabilities() and InputDeviceInfo.getCapabilities().

Bug:  823831 ,  817769 
Change-Id: Ifdc0e560001e000b12c8d04634d3c52de0a34cc7
Reviewed-on: https://chromium-review.googlesource.com/977251
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#545750}
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/content/public/renderer/media_stream_utils.cc
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/content/renderer/media/stream/media_stream_center.cc
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/content/renderer/media/stream/remote_media_stream_track_adapter.cc
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/content/renderer/media/stream/user_media_processor.cc
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-enumerateDevices.https.html
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-getCapabilities.https.html
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/third_party/WebKit/Source/modules/mediastream/InputDeviceInfo.cpp
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/third_party/WebKit/Source/modules/mediastream/MediaTrackCapabilities.idl
[modify] https://crrev.com/6520f685d3ec41fcd4bafec8fd7b3038920d5186/third_party/WebKit/public/platform/WebMediaStreamSource.h

Comment 12 by c.pa...@samsung.com, Apr 23 2018 

guidou@ Can we close this bug? Also, I would like to continue with my contributions. Please let me know if there's anything interesting that I can take up next? Thanks.

Comment 13 by guidou@chromium.org, Apr 23 2018

Status: Fixed (was: Assigned)

Comment 14 by anatolid@chromium.org, Jun 7 2018 

[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?
►

Sign in to add a comment