New issue
Advanced search Search tips

Issue 817753 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q2

Blocking:
issue 843571
issue 848876



Sign in to add a comment

Adaptive Toolbar: Change the color of the infobars

Project Member Reported by gambard@chromium.org, Mar 1 2018

Issue description

The infobars background color should match the toolbar.
Investigate if it is possible to have the infobar with a blur effect.
 
Labels: -Q1 Q2
Cc: pkl@chromium.org
Components: -UI>Browser>Toolbar UI>Browser
Labels: -MS-Adaptive-Toolbar -S-Visual-Polish MS-Notification
Owner: martijnb@chromium.org
Not sure if this is still needed. Sending it to Martijn for opinion.
The idea was to have the infobar the same color as the other "almost white" elements (NTP, popup menu...), 98% white.

Comment 3 by pkl@chromium.org, May 17 2018

Cc: pschaffner@chromium.org
This is related to question #6 in  issue 843571 

Comment 4 by pkl@chromium.org, May 17 2018

Blocking: 843571
Cc: martijnb@chromium.org
Owner: gambard@chromium.org
This is still needed. Originally I had suggested making the toolbar have knowledge of the infobar and thus changing the height of the toolbar to accommodate a [transparent background] infobar. This obviously is a bad idea and doesn't scale, so I suggest we just use the same kind of visual effect background view as that used in the toolbar, place a "separator" line along the bottom edge of the infobar view (say a 1pt high rect that spans the width of the infobar with a background color of white inside the vibrancy content view). We can then sprinkle in some logic to show/hide the separator view in certain size classes (Any x Compact or Regular x Any) and maybe also when we are in fullscreen for Compact x Regular (not sure if there is a global notification posted for fullscreen that we can use ... if no it isn't worth coupling the two areas of code).
I imagine it looking like this (shown with a colorful background to illustrate the subtle transparency).
Screen Shot 2018-05-18 at 13.48.01.png
175 KB View Download

Comment 7 by pkl@chromium.org, May 18 2018

Cc: gambard@chromium.org
Owner: pkl@chromium.org
This has more to do with infobar than toolbar, so taking it back.

Comment 8 by pkl@chromium.org, Jun 1 2018

Blocking: 848876

Comment 9 by pkl@chromium.org, Jun 1 2018

 Issue 848876  has been merged into this issue.

Comment 10 by pkl@chromium.org, Jun 1 2018

Owner: ----
Status: Available (was: Assigned)
Owner: gambard@chromium.org
Status: Assigned (was: Available)
Use #fafafa, no blur.
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aefab4ccb6631af2895726d8e2487e3419b7bea7

commit aefab4ccb6631af2895726d8e2487e3419b7bea7
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Jul 03 06:49:37 2018

[iOS] Change the background color of the infobars

This CL changes the background color of the infobars to be more aligned
with the UI Refresh look.

Bug:  817753 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I06db3d63b619fc63bf381d936f4c59cab4afaa28
Reviewed-on: https://chromium-review.googlesource.com/1122860
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572129}
[modify] https://crrev.com/aefab4ccb6631af2895726d8e2487e3419b7bea7/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
[modify] https://crrev.com/aefab4ccb6631af2895726d8e2487e3419b7bea7/ios/chrome/browser/ui/infobars/BUILD.gn
[modify] https://crrev.com/aefab4ccb6631af2895726d8e2487e3419b7bea7/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
[add] https://crrev.com/aefab4ccb6631af2895726d8e2487e3419b7bea7/ios/chrome/browser/ui/infobars/infobar_constants.h
[add] https://crrev.com/aefab4ccb6631af2895726d8e2487e3419b7bea7/ios/chrome/browser/ui/infobars/infobar_constants.mm

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)

Tested on 69.0.3487.0 Canary, iPhone X  iOS 11.4, it looks different than the image in comment #6, is this WAI?
https://drive.google.com/file/d/1RYe0uyxm8NUJbph6qL0fbTCVbf2nvbMP/view
Status: Fixed (was: Assigned)
Yes, if you look at comment #11, we decided to just change the color to FAFAFA and not extending the blur.
Status: Verified (was: Fixed)
Verified on 69.0.3487.0 Canary, iPhone X  iOS 11.4,
Looks good.

Sign in to add a comment