Adaptive Toolbar: Update buttons selected state |
||||||||||||
Issue descriptionThe selected state should be either a rounded corner square with a lighter background than the button, or no background and a different tint color (#000 @ 0.7 opacity).
,
Mar 7 2018
,
Mar 14 2018
The NextAction date has arrived: 2018-03-14
,
Mar 15 2018
,
Mar 28 2018
The NextAction date has arrived: 2018-03-28
,
Apr 3 2018
,
Apr 11 2018
Pete: What should be the specs for the active state in Incognito? Is it also a rectangle when selecting the omnibox shortcut?
,
Apr 11 2018
,
Apr 11 2018
,
Apr 12 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06ca303bc30849d0b3886d39e8fe58322f2c381f commit 06ca303bc30849d0b3886d39e8fe58322f2c381f Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Apr 13 12:18:04 2018 Add Spotlighted state to the toolbar button This CL adds a state to the toolbar button. This new state, "Spotlighted" is used to put emphasis on a button in the toolbar. It can be used to show that the page is bookmarked, or to indicate to which button the popup menu displayed is linked (done in a future CL). Bug: 817752 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I954cb0b26a577212ca8e3d8840b99f5be4aa1a2d Reviewed-on: https://chromium-review.googlesource.com/1000785 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550597} [modify] https://crrev.com/06ca303bc30849d0b3886d39e8fe58322f2c381f/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_egtest.mm [modify] https://crrev.com/06ca303bc30849d0b3886d39e8fe58322f2c381f/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm [modify] https://crrev.com/06ca303bc30849d0b3886d39e8fe58322f2c381f/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.h [modify] https://crrev.com/06ca303bc30849d0b3886d39e8fe58322f2c381f/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm [modify] https://crrev.com/06ca303bc30849d0b3886d39e8fe58322f2c381f/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm
,
Apr 16 2018
The NextAction date has arrived: 2018-04-16
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/657689fc10f19dbe7e94a36cbe91b02789ac61d9 commit 657689fc10f19dbe7e94a36cbe91b02789ac61d9 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Apr 17 07:34:23 2018 Change the spotlight put on toolbar buttons This CL changes the way the toolbar button associated with a popup menu is spotlighted. It reduces the alpha of the buttons. This is used to reduce the alpha of the background of the omnibox button to prevent confusion between the spotlighted button and the omnibox button. It also changes the color of the spotlight in incognito, making it white instead of dark. Bug: 817752 , 832076 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iee6797945df2e9ec65464ca0393789eb3b581e71 Reviewed-on: https://chromium-review.googlesource.com/1014124 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551272} [modify] https://crrev.com/657689fc10f19dbe7e94a36cbe91b02789ac61d9/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm [modify] https://crrev.com/657689fc10f19dbe7e94a36cbe91b02789ac61d9/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.h [modify] https://crrev.com/657689fc10f19dbe7e94a36cbe91b02789ac61d9/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.mm [modify] https://crrev.com/657689fc10f19dbe7e94a36cbe91b02789ac61d9/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h [modify] https://crrev.com/657689fc10f19dbe7e94a36cbe91b02789ac61d9/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm [modify] https://crrev.com/657689fc10f19dbe7e94a36cbe91b02789ac61d9/ios/chrome/browser/ui/toolbar/buttons/toolbar_tools_menu_button.mm
,
Apr 17 2018
,
Apr 17 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06ca303bc30849d0b3886d39e8fe58322f2c381f commit 06ca303bc30849d0b3886d39e8fe58322f2c381f Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Apr 13 12:18:04 2018 Add Spotlighted state to the toolbar button This CL adds a state to the toolbar button. This new state, "Spotlighted" is used to put emphasis on a button in the toolbar. It can be used to show that the page is bookmarked, or to indicate to which button the popup menu displayed is linked (done in a future CL). Bug: 817752 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I954cb0b26a577212ca8e3d8840b99f5be4aa1a2d Reviewed-on: https://chromium-review.googlesource.com/1000785 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550597} [modify] https://crrev.com/06ca303bc30849d0b3886d39e8fe58322f2c381f/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_egtest.mm [modify] https://crrev.com/06ca303bc30849d0b3886d39e8fe58322f2c381f/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm [modify] https://crrev.com/06ca303bc30849d0b3886d39e8fe58322f2c381f/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.h [modify] https://crrev.com/06ca303bc30849d0b3886d39e8fe58322f2c381f/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm [modify] https://crrev.com/06ca303bc30849d0b3886d39e8fe58322f2c381f/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm
,
Apr 25 2018
The NextAction date has arrived: 2018-04-25
,
Apr 25 2018
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by gambard@chromium.org
, Mar 7 2018