New issue
Advanced search Search tips

Issue 817723 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

CSS Animations: perspective should be responsive to inherited changes

Project Member Reported by ericwilligers@chromium.org, Mar 1 2018

Issue description

If the inherited perspective was 'none', but changes to a length while an animation from 'inherit' is in progress, the animation should progress from the inherited length.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f550e6bb2fa809ea522ec62a28d860432a6ce146

commit f550e6bb2fa809ea522ec62a28d860432a6ce146
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Fri Mar 02 20:10:32 2018

CSS Animations: keyword->length animation responsive

Animations having 'inherit' as a property's keyframe value
are now responsive if the inherited value changes from a
keyword to a length.

e.g.
perspective changes from 'none'
baseline-shift changes from 'sub'
row-gap or column-gap or line-height change from 'normal'
column-width change from 'auto'

We were already responsive if the inherited value changed
from a length to a keyword, or changed keyword.

BUG= 817723 

Change-Id: Ie1063a96d2487af05f5640c9df48ece86001b32c
Reviewed-on: https://chromium-review.googlesource.com/942505
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540600}
[add] https://crrev.com/f550e6bb2fa809ea522ec62a28d860432a6ce146/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-baselineShift.html
[add] https://crrev.com/f550e6bb2fa809ea522ec62a28d860432a6ce146/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-columnGap.html
[add] https://crrev.com/f550e6bb2fa809ea522ec62a28d860432a6ce146/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-columnWidth.html
[add] https://crrev.com/f550e6bb2fa809ea522ec62a28d860432a6ce146/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-lineHeight.html
[modify] https://crrev.com/f550e6bb2fa809ea522ec62a28d860432a6ce146/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-perspective.html
[add] https://crrev.com/f550e6bb2fa809ea522ec62a28d860432a6ce146/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-rowGap.html
[modify] https://crrev.com/f550e6bb2fa809ea522ec62a28d860432a6ce146/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp

Status: Fixed (was: Started)

Sign in to add a comment