New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817722 link

Starred by 1 user
Status: Fixed
Owner:
h...@chromium.org
Closed: Mar 2018
Cc:
█ fayang@chromium.org
thakis@chromium.org
inglorion@chromium.org
r...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

MSVC Win build fails compile step

Project Member Reported by h...@chromium.org, Mar 1 2018 
Seems to have started failing this morning.

From https://ci.chromium.org/buildbot/chromium.clang/CrWinClang/2553:

FAILED: obj/net/net/quic_framer.obj 
ninja -t msvc -e environment.x86 -- C:\b\c\goma_client/gomacc.exe "c:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\vc\tools\msvc\14.11.25503\bin\hostx64\x86/cl.exe" /nologo /showIncludes  -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000000 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DDLOPEN_KERBEROS -DNET_IMPLEMENTATION -DUSE_KERBEROS -DENABLE_BUILT_IN_DNS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=wchar_t -I../.. -Igen -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../third_party/zlib -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/brotli/include /wd4117 /D__DATE__= /D__TIME__= /D__TIMESTAMP__= /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- /W4 /WX /utf-8 /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /wd4267 /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /MT /TP /wd4577 /GR- /c ../../net/quic/core/quic_framer.cc /Foobj/net/net/quic_framer.obj /Fd"obj/net/net_cc.pdb"
../../net/quic/core/quic_framer.cc(1545): error C2220: warning treated as error - no 'object' file generated
../../net/quic/core/quic_framer.cc(1545): warning C4389: '==': signed/unsigned mismatch

Comment 1 by h...@chromium.org, Mar 1 2018

Cc: fayang@chromium.org
Brought in by fayang's https://chromium-review.googlesource.com/941586

Comment 2 by h...@chromium.org, Mar 1 2018

Owner: h...@chromium.org
Status: Started (was: Available)
The warning got through the CQ due to it only firing on 32-bit builds.

Here's a fix: https://chromium-review.googlesource.com/c/chromium/src/+/941945
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/151f8d4cb79a6ab60259b08d4b4373bcc05ded24

commit 151f8d4cb79a6ab60259b08d4b4373bcc05ded24
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Mar 01 12:33:56 2018

quic_framer.cc: Fix MSVC warning about signed/unsigned mismatch in comparison

num_ack_blocks is a uint8_t, so "num_ack_blocks - 1" would have type int, causing
MSVC to warn.

TBR=rch

Bug:  817722 
Change-Id: I4d9cbc0cf266dc00174ab73f66d80e56fc007ad2
Reviewed-on: https://chromium-review.googlesource.com/941945
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540133}
[modify] https://crrev.com/151f8d4cb79a6ab60259b08d4b4373bcc05ded24/net/quic/core/quic_framer.cc

Comment 4 by h...@chromium.org, Mar 1 2018

Status: Fixed (was: Started)
The bots are green.
►

Sign in to add a comment