New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817713 link

Starred by 1 user
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Misalignment of text and button is seen for 'open chrome webstore' option after changing browser language.

Reported by vku...@etouch.net, Mar 1 2018 
Chrome Version:66.0.3358.0 (Official Build)Revision 16fdb6c5f5d6e5779983e253b5f7c8bdd1cac610-refs/heads/master@{#539998} (32/64-bit)
OS:Win(7,8,8.1,10)

What steps will reproduce the problem?
(1)Launch chrome login with valid credentials, navigate to chrome://settings/ > Languages  and select 'French' language from 'Add languages' list.
(2)Click on iron icon of french language and click on 'display google chrome...' > relaunch 
(3)Navigate to chrome://extensions/ , click on main menu and observe 'open chrome webstore' option.

Actual: Misalignment of text and button is seen for 'open chrome webstore' option after changing browser language.

Expected: Text and button for 'open chrome webstore' option should be properly displayed after changing browser language.

This is a regression issue broken in 'M65' and below is the manual bisect info
Good Build: 64.0.3282.0 (Revision:520841) 
Bad Build:  65.0.3283.0 (Revision:521170) 

Note:Issue not seen on Mac(10.12.6, 10.13.1, 10.13.4) & Linux(14.04 LTS)
Actual_Result.png
72.6 KB View Download
Expected_Result.png
73.4 KB View Download

Comment 1 by vku...@etouch.net, Mar 1 2018

Cc: pbomm...@chromium.org
Labels: hasbisect-per-revision RegressedIn-65 FoundIn-66 Target-66 Target-65 FoundIn-65
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 520938 (known good), but no later than 520939 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/67dc496d6933b65092528bed4a995eef44a24ac9..394df2ded0fe41b2930987e77c4b81e67351b20a

Suspect: https://chromium.googlesource.com/chromium/src/+/394df2ded0fe41b2930987e77c4b81e67351b20a 

@scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note: Issue is seen on both the cases i.e with/without enabling flag --site-per-process

Comment 2 by scottchen@chromium.org, Mar 1 2018

Status: Started (was: Assigned)

Comment 3 by scottchen@chromium.org, Mar 6 2018 

Screenshot after fix
Screen Shot 2018-03-05 at 5.06.11 PM.png
209 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b01fd98e885fd61e6bce9408c7aa80ade6fcc72

commit 2b01fd98e885fd61e6bce9408c7aa80ade6fcc72
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Mar 06 21:10:17 2018

Extensions: fix navigation long text layout

Bug:  817713 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8c2723eb80a9301e74048df4e2b1e65a03b8ea61
Reviewed-on: https://chromium-review.googlesource.com/943523
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541191}
[modify] https://crrev.com/2b01fd98e885fd61e6bce9408c7aa80ade6fcc72/chrome/browser/resources/md_extensions/sidebar.html

Comment 5 by mencinares@google.com, Mar 7 2018

Components: -UI>Localization UI>Browser
Labels: Needs-TestConfirmation
Hi,

This is not a localization issue since the issue is all about misalignment but any strings was translated properly when navigate.

We will be looping in the Engineering Team for review.

Regards!

Comment 6 by vku...@etouch.net, Mar 7 2018

Labels: -Needs-TestConfirmation
Update:
Rechecked the above issue on latest canary i.e 67.0.3364.0 (Official Build) on Win(7,8,8.1,10) OS and the issue seems to be fixed.Kindly review an attached screen cast.
Actual_Canary.mp4
155 KB View Download

Comment 7 by vku...@etouch.net, Mar 7 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3364.0

Comment 8 by scottchen@chromium.org, Mar 7 2018

Status: Fixed (was: Started)
►

Sign in to add a comment