New issue
Advanced search Search tips

Issue 817709 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make TabbedPane a11y works in CrOS

Project Member Reported by wutao@chromium.org, Mar 1 2018

Issue description

Currently the following a11y behaviors are not as expected:
1. "search + space" cannot select a tab.
2. "search + left arrow" navigate tabs got "ignored" info instead of the tab's label text.
3. left/right arrows to navigate tabs in vertical mode is not intuitive. Need to use up/down arrows.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3ca0eaf837ef27d9313e4e1f922677e04deca98

commit a3ca0eaf837ef27d9313e4e1f922677e04deca98
Author: wutao <wutao@chromium.org>
Date: Fri Mar 02 05:10:23 2018

Make TabbedPane a11y work properly in CrOS.

This patch makes the a11y work properly in Chrome OS.
1. "search + space" can select a tab.
2. "search + left arrow" navigating tabs can get correct label text.
3. Use up/down arrows to navigate tabs in vertical mode.

Bug:  817709 , 768932
Test: tested on device and passed TabbedPaneTest.
Change-Id: I052e60428bf123f3346fae9bbb3255c172e42fd8
Reviewed-on: https://chromium-review.googlesource.com/942693
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540449}
[modify] https://crrev.com/a3ca0eaf837ef27d9313e4e1f922677e04deca98/ui/views/controls/tabbed_pane/tabbed_pane.cc

Comment 2 by wutao@chromium.org, Mar 6 2018

Status: Fixed (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efc900171c786053169e7e04917a8e17b723135b

commit efc900171c786053169e7e04917a8e17b723135b
Author: wutao <wutao@chromium.org>
Date: Wed Mar 07 18:47:09 2018

M66 merge: Make TabbedPane a11y work properly in CrOS.

This patch makes the a11y work properly in Chrome OS.
1. "search + space" can select a tab.
2. "search + left arrow" navigating tabs can get correct label text.
3. Use up/down arrows to navigate tabs in vertical mode.

TBR=tapted@chromium.org,msw@chromium.org,dmazzoni@chromium.org

Bug:  817709 , 768932
Test: tested on device and passed TabbedPaneTest.
Change-Id: I052e60428bf123f3346fae9bbb3255c172e42fd8
Reviewed-on: https://chromium-review.googlesource.com/942693
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540449}(cherry picked from commit a3ca0eaf837ef27d9313e4e1f922677e04deca98)
Reviewed-on: https://chromium-review.googlesource.com/952872
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#65}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/efc900171c786053169e7e04917a8e17b723135b/ui/views/controls/tabbed_pane/tabbed_pane.cc

Sign in to add a comment