New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817706 link

Starred by 2 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Mar 2018
Cc:
ajha@chromium.org
jen...@chromium.org
█ brajkumar@chromium.org
tbuck...@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Connected Wi-Fi network is seen at bottom of Wi-Fi networks in Uber Tray

Project Member Reported by mmanchala@chromium.org, Mar 1 2018 
Chrome Version: 66.0.3357.0/10448.0.0 Daisy,Kip and Cyan 
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Sign out -> In Sign-out screen -> click on Uber Tray
(2)Select Network option(i.e. 'Connected to....')  -> Observe Connected Wi-Fi network is seen at top of Wi-Fi networks
(3)After few seconds observe Connected Wi-Fi network is seen at bottom
(Please refer Video and Screenshot)

Expected: Connected Wi-Fi network should be seen at top of Wi-Fi networks
Actual: Instead Connected Wi-Fi network is seen at bottom

This is Regression issue as same is working fine in 66.0.3344.0/10399.0.0 dev-channel Kip

@tbuckley : Please confirm the Issue

Note : Issue is working fine in M-63, M-64 and on M-65
Actual_ConnectedWi-FiNetworkIsseenAtBottom.webm
2.5 MB View Download
Actual_ConnectedWi-FiNetworkIsseenAtBottom.jpg
430 KB View Download
Expected_ConnectedWi-FiNetwork.webm
3.2 MB View Download
Expected_ConnectedWi-FiNetwork.jpg
322 KB View Download

Comment 1 by jamescook@chromium.org, Mar 1 2018 

I also saw this:
Google Chrome	66.0.3357.0 (Official Build) canary (64-bit)
Revision	0
Platform	10446.0.0 (Official Build) canary-channel samus
Firmware Version	Google_Samus.6300.276.0

It also looked like the networks were maybe reverse-sorted by signal strength, not sure.
Screenshot 2018-03-01 at 8.48.50 AM.png
225 KB View Download
Screenshot 2018-03-01 at 8.48.57 AM.png
764 KB View Download

Comment 2 by steve...@chromium.org, Mar 1 2018

Cc: tbuck...@chromium.org
Owner: steve...@chromium.org
Status: Started (was: Assigned)
Yea, I saw this recently also, was planning to investigate. Thanks for filing an issue.

Comment 3 by steve...@chromium.org, Mar 1 2018 

It looks like this is something I introduced fixing another bug, I'm on it.

Comment 4 by steve...@chromium.org, Mar 1 2018

Cc: jen...@chromium.org
The bug was introduced here:
https://chromium-review.googlesource.com/920790

Part of my change there was incorrect and unnecessary to fix the crash, reverting that part.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb670e0da6d028a0eec7b0a1b7b8e9c753cbfd53

commit bb670e0da6d028a0eec7b0a1b7b8e9c753cbfd53
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Mar 02 17:00:39 2018

Partial revert of Network List: Fix edge case

Bug was introduced here:
https://chromium-review.googlesource.com/920790

Change introducing the bug was not actually related to the fix
in that CL.

Bug:  817706 
Change-Id: I9e73f05fe66745b1b7651333a6d715c682018a1a
Reviewed-on: https://chromium-review.googlesource.com/944161
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540536}
[modify] https://crrev.com/bb670e0da6d028a0eec7b0a1b7b8e9c753cbfd53/ash/system/network/network_list.cc
[modify] https://crrev.com/bb670e0da6d028a0eec7b0a1b7b8e9c753cbfd53/ash/system/network/network_list.h

Comment 6 by steve...@chromium.org, Mar 2 2018

Status: Fixed (was: Started)
Project Member

Comment 7 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Mar 2 2018

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-66; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-66 label, otherwise remove Merge-TBD label. Thanks.

Comment 8 by steve...@chromium.org, Mar 2 2018

Labels: -Merge-TBD Merge-Request-66
Project Member

Comment 9 by sheriffbot@chromium.org, Mar 3 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 5 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66eeb7e01f81f4c6294ddd762bdc2c8ad0396193

commit 66eeb7e01f81f4c6294ddd762bdc2c8ad0396193
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Mar 05 22:52:58 2018

Partial revert of Network List: Fix edge case

Bug was introduced here:
https://chromium-review.googlesource.com/920790

Change introducing the bug was not actually related to the fix
in that CL.

TBR=stevenjb@chromium.org

(cherry picked from commit bb670e0da6d028a0eec7b0a1b7b8e9c753cbfd53)

Bug:  817706 
Change-Id: I9e73f05fe66745b1b7651333a6d715c682018a1a
Reviewed-on: https://chromium-review.googlesource.com/944161
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540536}
Reviewed-on: https://chromium-review.googlesource.com/949965
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#16}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/66eeb7e01f81f4c6294ddd762bdc2c8ad0396193/ash/system/network/network_list.cc
[modify] https://crrev.com/66eeb7e01f81f4c6294ddd762bdc2c8ad0396193/ash/system/network/network_list.h
►

Sign in to add a comment