New issue
Advanced search Search tips

Issue 817705 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 819194

Blocking:
issue 694855



Sign in to add a comment

Layout Test http/tests/media/media-src-suspend-before-have-metadata.html is flaky

Project Member Reported by horo@chromium.org, Mar 1 2018

Issue description

The following layout test is flaky on Linux/Mac/Win

http/tests/media/media-src-suspend-before-have-metadata.html

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=media-src-suspend-before-have-metadata.html
 

Comment 1 by horo@chromium.org, Mar 1 2018

Blocking: 694855
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9775f9b3fcf64ce57a089f1e6463cfdbf0f22d67

commit 9775f9b3fcf64ce57a089f1e6463cfdbf0f22d67
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Mar 01 08:39:49 2018

Mark media-src-suspend-before-have-metadata.html as flaky

TBR: dalecurtis@chromium.org
Bug:  817705 
Change-Id: Ib8ee6bc048b39aadd1ac3dc69fd4aadb1176ec49
Reviewed-on: https://chromium-review.googlesource.com/942596
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540104}
[modify] https://crrev.com/9775f9b3fcf64ce57a089f1e6463cfdbf0f22d67/third_party/WebKit/LayoutTests/TestExpectations

I think it just needs to be a SlowTest; I don't see any true failures. I'll fix these and the others today.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a49d6f3feaa1fd2d4af3c61f718ce09a1ea7a300

commit a49d6f3feaa1fd2d4af3c61f718ce09a1ea7a300
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Mar 06 01:01:57 2018

Move src= suspend tests into SlowTests.

These should just be slow not flakily fail.

BUG= 817705 , 694855 

Change-Id: I371f57744442eebad53aea566b751df47d8b9a9e
Reviewed-on: https://chromium-review.googlesource.com/950142
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541011}
[modify] https://crrev.com/a49d6f3feaa1fd2d4af3c61f718ce09a1ea7a300/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/a49d6f3feaa1fd2d4af3c61f718ce09a1ea7a300/third_party/WebKit/LayoutTests/TestExpectations

Blockedon: 819194
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6438cf1ff7f9e249d150b5dc22d0157193c09cac

commit 6438cf1ff7f9e249d150b5dc22d0157193c09cac
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Thu Mar 29 02:34:01 2018

Simplify suspend/resume testing by having WMP suspend based on state.

This removes the need for stalled loading to force states on the WMPI
pipeline by instead having WMPI suspend once it reaches one of the
target states.

This provides equivalent coverage with much faster testing.

BUG= 819194 , 817705 , 756897 
TEST=no more flaky tests.

Change-Id: I1fa9e1ff6d165ed7921abf62127d3c2cd89f5707
Reviewed-on: https://chromium-review.googlesource.com/980802
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546704}
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/LayoutTests/ASANExpectations
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/LayoutTests/MSANExpectations
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/dae40d733338a3c54add2a9385674e9094cd04bb/third_party/WebKit/LayoutTests/http/tests/media/media-src-suspend-after-have-future-data.html
[delete] https://crrev.com/dae40d733338a3c54add2a9385674e9094cd04bb/third_party/WebKit/LayoutTests/http/tests/media/media-src-suspend-after-have-metadata.html
[delete] https://crrev.com/dae40d733338a3c54add2a9385674e9094cd04bb/third_party/WebKit/LayoutTests/http/tests/media/media-src-suspend-before-have-metadata.html
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/LayoutTests/media/media-src-suspend-after-have-enough-data.html
[add] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/LayoutTests/media/media-src-suspend-after-have-future-data.html
[add] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/LayoutTests/media/media-src-suspend-after-have-metadata.html
[add] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/LayoutTests/media/media-src-suspend-before-have-metadata.html
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/LayoutTests/media/suspend-util.js
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/6438cf1ff7f9e249d150b5dc22d0157193c09cac/third_party/WebKit/public/platform/WebMediaPlayer.h

Status: Fixed (was: Assigned)

Sign in to add a comment