New issue
Advanced search Search tips

Issue 817698 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Remove Permissions Blacklist code

Project Member Reported by timloh@chromium.org, Mar 1 2018

Issue description

Unfortunately we are unlikely to end up using permissions blacklisting. We've decided to remove it for now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b

commit 8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b
Author: Timothy Loh <timloh@chromium.org>
Date: Thu Mar 15 03:34:30 2018

Delete permissions blacklisting code

We've decided to not proceed with permission blacklisting for now. This
patch deletes the blacklisting code which is now effectively dead.

Bug:  817698 
Change-Id: Ifb490c4c77ee1dc66610dd640c534bc3b4c64df3
Reviewed-on: https://chromium-review.googlesource.com/956645
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543298}
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/BUILD.gn
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/about_flags.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/flag_descriptions.h
[delete] https://crrev.com/c55c06c517d56afa498d3757e24c20604f9a1bd1/chrome/browser/permissions/permission_blacklist_client.cc
[delete] https://crrev.com/c55c06c517d56afa498d3757e24c20604f9a1bd1/chrome/browser/permissions/permission_blacklist_client.h
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/permissions/permission_context_base.h
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/permissions/permission_decision_auto_blocker.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/permissions/permission_decision_auto_blocker.h
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/permissions/permission_result.h
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/permissions/permission_util.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/permissions/permission_util.h
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/ui/page_info/page_info_ui.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/common/chrome_features.cc
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/chrome/common/chrome_features.h
[modify] https://crrev.com/8fbdac5b5eb3b8ed3dcf01ba867b0138641b160b/tools/metrics/histograms/histograms.xml

Comment 2 by timloh@chromium.org, Mar 15 2018

Status: Fixed (was: Assigned)
Removed now (in M67).

Sign in to add a comment