New issue
Advanced search Search tips

Issue 817678 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Jun 2018
Cc:
pfeldman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Layout Test http/tests/devtools/console/console-group-similar.js is flaky

Project Member Reported by horo@chromium.org, Mar 1 2018 
The following layout test is failing on Windows

http/tests/devtools/console/console-group-similar.js

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=http/tests/devtools/console/console-group-similar.js


Probable cause:

Maybe a timing issue.

https://test-results.appspot.com/data/layout_results/WebKit_Win7/60971/layout-test-results/http/tests/devtools/console/console-group-similar-diff.txt


--- e:\b\swarm_slave\w\iokr3nhx\layout-test-results\http/tests/devtools/console/console-group-similar-expected.txt
+++ e:\b\swarm_slave\w\iokr3nhx\layout-test-results\http/tests/devtools/console/console-group-similar-actual.txt
@@ -17,11 +17,11 @@
 "evaluated command"
 console-group-similar.js:19 Uncaught (in promise) undefined
 (anonymous) @ console-group-similar.js:19
+console-group-similar.js:19 Uncaught (in promise) undefined
+(anonymous) @ console-group-similar.js:19
 ConsoleAPI log
 'evaluated command'
 "evaluated command"
-console-group-similar.js:19 Uncaught (in promise) undefined
-(anonymous) @ console-group-similar.js:19
 ConsoleAPI log
 'evaluated command'
 "evaluated command"
@@ -51,12 +51,12 @@
 console-group-similar.js:19 Uncaught (in promise) undefined
 (anonymous) @ console-group-similar.js:19
 [Violation] Verbose-level violation
+console-group-similar.js:19 Uncaught (in promise) undefined
+(anonymous) @ console-group-similar.js:19
 [Violation] Error-level violation
 ConsoleAPI log
 'evaluated command'
 "evaluated command"
-console-group-similar.js:19 Uncaught (in promise) undefined
-(anonymous) @ console-group-similar.js:19
 [Violation] Verbose-level violation
 [Violation] Error-level violation
 ConsoleAPI log
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3c25058b952f0add4251c0fa23f875701354487

commit d3c25058b952f0add4251c0fa23f875701354487
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Mar 01 04:40:55 2018

Mark console-group-similar.js as flaky on Windows

TBR: luoe@chromium.org
Bug:  817678 
Change-Id: I0c9aec842b49210503d38f25aacb42824412ec2b
Reviewed-on: https://chromium-review.googlesource.com/942643
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540053}
[modify] https://crrev.com/d3c25058b952f0add4251c0fa23f875701354487/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8ad315445aee33d62ed9bbb72c5bda9dd283546

commit d8ad315445aee33d62ed9bbb72c5bda9dd283546
Author: Erik Luo <luoe@chromium.org>
Date: Fri Jun 01 18:55:42 2018

DevTools: de-flake console-group-similar.js

Test flaked because the error generated by Promise.reject() could be
received in the next microtask, affecting the order of results.

This CL replaces the Promise error with a synchronous ReferenceError.

Bug:  817678 
Change-Id: Idffc01f3ed9147de5e5c1b834b20507f70a3fe20
Reviewed-on: https://chromium-review.googlesource.com/1081071
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563742}
[modify] https://crrev.com/d8ad315445aee33d62ed9bbb72c5bda9dd283546/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d8ad315445aee33d62ed9bbb72c5bda9dd283546/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-group-similar-expected.txt
[modify] https://crrev.com/d8ad315445aee33d62ed9bbb72c5bda9dd283546/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-group-similar.js

Comment 3 by l...@chromium.org, Jun 2 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment