Get rid of net-diags.net.log in FB reports? It doesn't exist |
|||
Issue descriptionA sample feedback report: https://listnr.corp.google.com/product/208/report/85124077908 Its trying to look for a net-diags.net.log file. cat: /var/log/net-diags.net.log: No such file or directory Was added to feedback report here: https://chromium-review.googlesource.com/#/c/chromiumos/platform/debugd/+/39468/2/src/log_tool.cc I haven't seen this file on any system since 2016. Time to revert the log_tool.cc change?
,
Mar 13 2018
network_diag has always created files in the user's Download directory using names like network_diagnostics_<stamp>.txt. so i don't think it's coming from there. net-diags.net.log used to be created by shill, but it was deleted here: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/fb2f00f7a47d695e6a674a73f17f0cd453f9d5b0 looks like it was shortly after the CrOS->Android migration, and the commit message indicates no one ever cared. so we should delete references in debugd/etc... to the file.
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/aff50fc089c0e4d6bf6f8e76903db0b9e6032741 commit aff50fc089c0e4d6bf6f8e76903db0b9e6032741 Author: Kevin Cernekee <cernekee@chromium.org> Date: Thu Mar 22 01:30:45 2018 debugd: Remove obsolete net-diags.net.log This file is no longer created by shill. BUG= chromium:817671 TEST=manually visit chrome://system Change-Id: I9bce1a6e85f35202d13da23625e9e1181fd68b3b Reviewed-on: https://chromium-review.googlesource.com/972353 Commit-Ready: Kevin Cernekee <cernekee@chromium.org> Tested-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/aff50fc089c0e4d6bf6f8e76903db0b9e6032741/debugd/src/log_tool.cc
,
Sep 17
|
|||
►
Sign in to add a comment |
|||
Comment 1 by semenzato@chromium.org
, Mar 1 2018