New issue
Advanced search Search tips

Issue 817668 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 814664



Sign in to add a comment

Layout Test compositing/scroll-with-inner-clip.html is failing

Project Member Reported by horo@chromium.org, Mar 1 2018

Issue description

Comment 1 by horo@chromium.org, Mar 1 2018

Blocking: 814664
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/071f173d3fbc808bb35a378d65b4ba5b29a697a6

commit 071f173d3fbc808bb35a378d65b4ba5b29a697a6
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Mar 01 02:33:05 2018

Treat compositing/scroll-with-inner-clip.html as flaky

Bug:  817668 
TBR: vmpstr@chromium.org
Change-Id: I3014686dd916acf90c4f970714d7e1206c1672b1
Reviewed-on: https://chromium-review.googlesource.com/942501
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539996}
[modify] https://crrev.com/071f173d3fbc808bb35a378d65b4ba5b29a697a6/third_party/WebKit/LayoutTests/TestExpectations

Cc: chrishtr@chromium.org
Labels: -Pri-3 Pri-2
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd91b77da524c9151eacd51709dfe7d6cff874b4

commit fd91b77da524c9151eacd51709dfe7d6cff874b4
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Mon Mar 05 19:21:52 2018

[PE] Fix flaky layout test (scroll-with-inner-clip).

This patch changes the expectation from being a PNG to being a reftest.

The reference does very similar things as the test, but scrolls a
much smaller amount. The initial bug that caused this would still trip
up this test, since the result looked different based on the scroll
position.

This, however, prevents flaky tests on minor pixel differences due to
aliasing on the border radius.

R=chrishtr@chromium.org

Bug:  817668 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5ea729966965ed7f8c89a194d667f1c81e5b4c32
Reviewed-on: https://chromium-review.googlesource.com/947251
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540893}
[modify] https://crrev.com/fd91b77da524c9151eacd51709dfe7d6cff874b4/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/fd91b77da524c9151eacd51709dfe7d6cff874b4/third_party/WebKit/LayoutTests/compositing/scroll-with-inner-clip-expected.html
[delete] https://crrev.com/180a581c3ad6e4da6cb494b34d858721fd5e1a84/third_party/WebKit/LayoutTests/compositing/scroll-with-inner-clip-expected.png
[delete] https://crrev.com/180a581c3ad6e4da6cb494b34d858721fd5e1a84/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/scroll-with-inner-clip-expected.png
[delete] https://crrev.com/180a581c3ad6e4da6cb494b34d858721fd5e1a84/third_party/WebKit/LayoutTests/platform/mac-mac10.12/compositing/scroll-with-inner-clip-expected.png
[delete] https://crrev.com/180a581c3ad6e4da6cb494b34d858721fd5e1a84/third_party/WebKit/LayoutTests/platform/win/compositing/scroll-with-inner-clip-expected.png
[delete] https://crrev.com/180a581c3ad6e4da6cb494b34d858721fd5e1a84/third_party/WebKit/LayoutTests/virtual/disable-spv175/compositing/scroll-with-inner-clip-expected.png

Status: Fixed (was: Assigned)

Sign in to add a comment