New issue
Advanced search Search tips

Issue 817653 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: "Inspect" context menu in an OOPIF doesn't expand to element on first try

Project Member Reported by creis@chromium.org, Mar 1 2018

Issue description

Chrome Version: 66.0.3357.0
OS: Mac OSX

What steps will reproduce the problem?
(1) Start Chrome with --site-per-process
(2) Visit http://csreis.github.io/tests/cross-site-iframe.html
(3) Click "Go cross-site (simple page)"
(4) Close DevTools if it happens to be open
(5) Right click on "csreis.github.io" and choose "Inspect"
(6) Repeat step 5.

What is the expected result?
The <body>csreis.github.io</body> element should be expanded and highlighted after step 5.

What happens instead?
No elements are expanded or highlighted after step 5.  When choosing "Inspect" again in step 6, the right element is expanded and highlighted.

This only seems to affect OOPIFs and not same-process frames.
 

Comment 1 by creis@chromium.org, Mar 1 2018

Labels: M-66 OS-Chrome OS-Linux OS-Windows
Confirmed on Windows and Linux as well.  Only affects M66 and later, when OOPIFs started being shown inline (in  issue 800613 ).
Labels: Merge-Request-66
Status: Started (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 6 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 6 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66b1004f7e866a2dc425cf25d8be7bbaca3d22f4

commit 66b1004f7e866a2dc425cf25d8be7bbaca3d22f4
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Tue Mar 06 23:26:54 2018

DevTools: "Inspect" context menu in an OOPIF doesn't expand to element on first try

TBR=pfeldman@chromium.org

(cherry picked from commit 6d73147be5f38fa6e988b2ce72b18edb7b93cd9e)

Bug:  817653 
Change-Id: I29fed9cfc734439aa4a97cf591dafc440232de12
Reviewed-on: https://chromium-review.googlesource.com/943938
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540337}
Reviewed-on: https://chromium-review.googlesource.com/952285
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#43}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[add] https://crrev.com/66b1004f7e866a2dc425cf25d8be7bbaca3d22f4/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-inspect-expected.txt
[add] https://crrev.com/66b1004f7e866a2dc425cf25d8be7bbaca3d22f4/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-elements-inspect.js
[add] https://crrev.com/66b1004f7e866a2dc425cf25d8be7bbaca3d22f4/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/resources/page-inspect.html
[modify] https://crrev.com/66b1004f7e866a2dc425cf25d8be7bbaca3d22f4/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

Status: Fixed (was: Started)

Sign in to add a comment