New issue
Advanced search Search tips

Issue 817648 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

Need a framework for debug info based tests

Project Member Reported by laszio@chromium.org, Mar 1 2018

Issue description

...such as compiler flag checks. In case compiler flags are changed accidentally, we need to know asap.

Regression tests such as making sure all new packages are built with clang can also be done by checking dwarf info to see it's producer.
 
Description: Show this description
Summary: Need a framework for debug info based tests (was: verify compiler flags)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/340542b21c30cd62a68d19f086edef36d849971b

commit 340542b21c30cd62a68d19f086edef36d849971b
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Sat Mar 03 04:47:16 2018

debug_info_test: Run tests based on debug info

debug_info_test calls tests on the given ELF files. When a directory is
supplied, all ELFs will be searched and tested recursively.

BUG= chromium:817648 
TEST=debug_info_test /build/kip/usr/lib/debug

Change-Id: Ibcb1ac2de19df9227eb6e242d611ec841d4b589f
Reviewed-on: https://chromium-review.googlesource.com/942465
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[add] https://crrev.com/340542b21c30cd62a68d19f086edef36d849971b/debug_info_test/clang_comp_path.whitelist
[add] https://crrev.com/340542b21c30cd62a68d19f086edef36d849971b/debug_info_test/whitelist.py
[add] https://crrev.com/340542b21c30cd62a68d19f086edef36d849971b/debug_info_test/clang_dso_path.whitelist
[add] https://crrev.com/340542b21c30cd62a68d19f086edef36d849971b/debug_info_test/check_cus.py
[add] https://crrev.com/340542b21c30cd62a68d19f086edef36d849971b/debug_info_test/check_clang.py
[add] https://crrev.com/340542b21c30cd62a68d19f086edef36d849971b/debug_info_test/debug_info_test.py

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 3 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a4a52bcd62a54755a97ac907e4c2c997b03cfacb

commit a4a52bcd62a54755a97ac907e4c2c997b03cfacb
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Sat Mar 03 08:45:13 2018

toolchain-utils: install scripts from toolchain-utils to SDK

This package pull some scripts from

    chromiumos/third_party/toolchain-utils

into SDK. In this patch only debug_info_test/ are installed.

BUG= chromium:817648 
CQ-DEPEND=CL:942465
TEST=sudo emerge toolchain-utils && /usr/bin/debug_info_test
     tryjob chromiumos-sdk passed && the packages is built

Change-Id: Ie0dfd8294df6ee40a5b241107108eb685b43ab65
Reviewed-on: https://chromium-review.googlesource.com/946883
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[modify] https://crrev.com/a4a52bcd62a54755a97ac907e4c2c997b03cfacb/chromeos-base/cros-devutils/cros-devutils-9999.ebuild
[add] https://crrev.com/a4a52bcd62a54755a97ac907e4c2c997b03cfacb/dev-util/toolchain-utils/toolchain-utils-9999.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 5 2018

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/bcf06d418d08c7ba535c8a648d1f0fb19de31974

commit bcf06d418d08c7ba535c8a648d1f0fb19de31974
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Tue Mar 06 17:59:18 2018

DebugInfoTest: perform tests based on debug info

Tests may include, for example,
   * whether dwarf info exists
   * whether clang is used
   * whether FORTIFY is enabled, etc.

BUG= chromium:817648 
TEST=cros tryjob kip-release-tryjob
                 daisy-release-tryjob
                 elm-release-tryjob

Change-Id: I8552c5fa4358fc8921c03bf823eba7e824624613
Reviewed-on: https://chromium-review.googlesource.com/945570
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/bcf06d418d08c7ba535c8a648d1f0fb19de31974/cbuildbot/stages/test_stages.py
[modify] https://crrev.com/bcf06d418d08c7ba535c8a648d1f0fb19de31974/cbuildbot/builders/simple_builders.py

Status: Fixed (was: Started)

Comment 9 by norvez@chromium.org, Mar 15 2018

Status: Assigned (was: Fixed)
DebugInfoTest is failing. For example: https://luci-milo.appspot.com/buildbot/chromeos/cave-paladin/3228
Owner: cmt...@chromium.org
Working on it...
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/5750315a56e4c3a6e601bdbaf449213cf2ffb65d

commit 5750315a56e4c3a6e601bdbaf449213cf2ffb65d
Author: Caroline Tice <cmtice@google.com>
Date: Fri Mar 16 04:23:34 2018

[toolchain-utils] Update whitelists for debug_info_test stage.

The debug_info_test stage verifies that everything that is supposed
to be built with LLVM is actually being built with LLVM.  We have
to whitelist a few files/packages that must continue to be built
with GCC.  This CL updates the whitelists to make this stage pass
on AMD64.

BUG= chromium:817648 
TEST= debug_info_test.py passed on my local terra build, with these
changes. DebugInfoTest stage passed on cros tryjob fizz-llvm-toolchain-tryjob.

Change-Id: Ia9c79b5f13663d1f8a0e2b948f03a532b46d270b
Reviewed-on: https://chromium-review.googlesource.com/964590
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/5750315a56e4c3a6e601bdbaf449213cf2ffb65d/debug_info_test/ngcc_comp_path.whitelist
[modify] https://crrev.com/5750315a56e4c3a6e601bdbaf449213cf2ffb65d/debug_info_test/ngcc_dso_path.whitelist

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment