New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817625 link

Starred by 3 users
Status: Fixed
Owner:
█ rjwright@chromium.org
Last visit > 30 days ago
Closed: Apr 2018
Cc:
benchan@chromium.org
nverne@chromium.org
chirantan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 813699



Sign in to add a comment

Make chromeos/platform/cros_system_api/vm_concierge/service.proto use LITE_RUNTIME

Project Member Reported by rjwright@chromium.org, Mar 1 2018 
Full runtime features are not needed for this proto at this time. Using the LITE_RUNTIME optimization option reduces its size and the number of features it needs to support.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/9fc51df7e1eb2261b2e40d5a750df7a8b78632fc

commit 9fc51df7e1eb2261b2e40d5a750df7a8b78632fc
Author: Renee Wright <rjwright@chromium.org>
Date: Thu Mar 01 05:30:18 2018

Make vm_concierge/service.proto optimize_for = LITE_RUNTIME

As far as I understand, this will restrict the inteface that
service.proto needs to implement. That interface should be
sufficient for now. This can be changed back if we need to
expand the capability of service.proto. I'm using
vm_concierge/service.proto to set up a Crostini setup client
in
https://chromium-review.googlesource.com/c/chromium/src/+/933321

BUG= 817625 
TEST=stanza
Change-Id: I2512a158655c688744529cec59f10407e7e51f77
Reviewed-on: https://chromium-review.googlesource.com/939002
Commit-Ready: Renée Wright <rjwright@chromium.org>
Tested-by: Renée Wright <rjwright@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/9fc51df7e1eb2261b2e40d5a750df7a8b78632fc/dbus/vm_concierge/service.proto

Comment 2 by tbuck...@chromium.org, Mar 15 2018

Labels: Proj-Containers

Comment 3 by rjwright@chromium.org, Apr 15 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment