New issue
Advanced search Search tips

Issue 817622 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
KSH



Sign in to add a comment

KSH Accessibility Enhancements

Project Member Reported by ovanieva@chromium.org, Mar 1 2018

Issue description

The below enhancements are suggestions from KSH accessibility review (non-launch blocking):

1) When displaying search results, Chromevox to announce: 
'showing results for X search term. Bonus: showing N number of results for X search term'

2) When no search results available, Chromevox to announce: 
'no search results for X search term'

3) When getting back to KSH from search results back - ensure ChromeVox focus is on search box not back button. 


 
Labels: KSH

Comment 2 by wutao@chromium.org, Mar 21 2018

Cc: dmazz...@chromium.org
+dmazzoni@, in the cases of 1&2, which view should speak?
User is typing the search box. The focus is at the search box and it will read the typed letters by default. Then which view can announce the searched results.

Comment 3 by wutao@chromium.org, Mar 23 2018

I will let search box to pronounce it.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d134d7b9fc356b2c7f3b34f1719d98f21a96737

commit 3d134d7b9fc356b2c7f3b34f1719d98f21a96737
Author: wutao <wutao@chromium.org>
Date: Sat Mar 24 05:49:01 2018

cros: KSV a11y to pronounce number of search results

This cl adds a11y support to pronounce how many search results are
displaying Keyboard Shortcut Viewer (KSV).

Bug: 757261,  817622 
Test: manual test.
Change-Id: Iaa79cb83dc3f97bb0e2ceb73b946116af39ad9de
Reviewed-on: https://chromium-review.googlesource.com/978457
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#545674}
[modify] https://crrev.com/3d134d7b9fc356b2c7f3b34f1719d98f21a96737/ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc
[modify] https://crrev.com/3d134d7b9fc356b2c7f3b34f1719d98f21a96737/ash/components/shortcut_viewer/views/ksv_search_box_view.cc
[modify] https://crrev.com/3d134d7b9fc356b2c7f3b34f1719d98f21a96737/ash/components/shortcut_viewer/views/ksv_search_box_view.h
[modify] https://crrev.com/3d134d7b9fc356b2c7f3b34f1719d98f21a96737/ash/components/shortcut_viewer_strings.grdp

Comment 5 by wutao@chromium.org, Mar 24 2018

Status: Fixed (was: Assigned)

Sign in to add a comment