when in VR Browsing - make it easier to get into incognito mode via an overflow menu for omnibox (UX spec forthcoming from gordonbrander@). assigning to gordonbrander@ first to get design then to cjgrant@ for costing/impl.
When we add an overflow menu, presumably it'd have more than just incogito from the get-go. Would we introduce it with Refresh and Forward as well?
Likely yes, since I am assuming this won't expand the scope much for M67. Does this sound right?
tenatively on Hotlist-VRB-MVP
per discussion w/cjgrant@, UX design is updated & approved. Over to Chris to begin work.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fec6a27ba8dc40adac3b0493451a379ff08f1b43 commit fec6a27ba8dc40adac3b0493451a379ff08f1b43 Author: Christopher Grant <cjgrant@chromium.org> Date: Mon Mar 19 18:49:59 2018 VR: Introduce a shell overflow menu This change adds an initial, non-functional overflow menu. It can be summoned, looks like an overflow menu, and has buttons and items. It does not yet: - Trigger any actions on clicks - Appear when hovering the overflow button - Update according to tab state - Expand to fit translated text These additions will come in follow-on changes. BUG= 817614 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I837f7a3b4cb0b151e9370ba3d7e2f2de00bd34bc Reviewed-on: https://chromium-review.googlesource.com/967256 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544087} [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/app/generated_resources.grd [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/elements/ui_element_type.cc [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/elements/ui_element_type.h [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/elements/url_bar_texture.cc [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/model/model.h [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/ui_scene_creator.h [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/ui_unittest.cc [modify] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/vector_icons/BUILD.gn [add] https://crrev.com/fec6a27ba8dc40adac3b0493451a379ff08f1b43/chrome/browser/vr/vector_icons/more_vert.icon
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d commit d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d Author: Christopher Grant <cjgrant@chromium.org> Date: Wed Mar 21 21:18:16 2018 VR: Wire up overflow menu tab control This change enables incognito tab spawning and closing of all incognito tabs from the new overflow menu. BUG= 817614 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0d5348ad2cbf740259d8cbd77be4437d59c480c4 Reviewed-on: https://chromium-review.googlesource.com/972156 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#544847} [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/browser_ui_interface.h [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/elements/button.cc [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/elements/button.h [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/elements/button_unittest.cc [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/model/model.h [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/test/mock_browser_ui_interface.h [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/test/mock_ui_browser_interface.h [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/testapp/vr_test_context.h [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/ui.cc [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/ui.h [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/ui_browser_interface.h [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/d5442b46cac481e04f2bcee4fd2d4582a8bf9a3d/chrome/browser/vr/ui_scene_creator.h
Comment 1 by cjgrant@chromium.org
, Mar 1 2018