[PIP] Enable contextual menu entry point. |
||||
Issue descriptionThis tracks re-enabling. the contextual menu entry point for Picture in Picture. This will be done after the end to end flow triggered via the media controls entry point is stable. Disabled at 817598.
,
Apr 18 2018
,
May 31 2018
,
Jun 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8ca81f8ed887c21094593f8b0481278b2b2ba0a commit f8ca81f8ed887c21094593f8b0481278b2b2ba0a Author: Jennifer Apacible <apacible@chromium.org> Date: Sun Jun 03 05:42:30 2018 [Picture in Picture] Wire up contextual menu item. This change allows users to enter Picture-in-Picture mode from the contextual menu item on videos. Previously, the item existed but was not wired up to the the rest of the Picture-in-Picture work. Bug: 817613 Change-Id: Ie1d644a6ba03799ecf7e86daef6c88c83f58dd1a Reviewed-on: https://chromium-review.googlesource.com/1075813 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#563960} [modify] https://crrev.com/f8ca81f8ed887c21094593f8b0481278b2b2ba0a/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/f8ca81f8ed887c21094593f8b0481278b2b2ba0a/third_party/blink/public/web/web_media_player_action.h [modify] https://crrev.com/f8ca81f8ed887c21094593f8b0481278b2b2ba0a/third_party/blink/renderer/core/exported/web_view_impl.cc [modify] https://crrev.com/f8ca81f8ed887c21094593f8b0481278b2b2ba0a/third_party/blink/renderer/core/frame/picture_in_picture_controller.h [modify] https://crrev.com/f8ca81f8ed887c21094593f8b0481278b2b2ba0a/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.h [modify] https://crrev.com/f8ca81f8ed887c21094593f8b0481278b2b2ba0a/tools/metrics/actions/actions.xml
,
Jun 5 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by apaci...@chromium.org
, Apr 6 2018