Sharing an ADM shared page fails |
||
Issue descriptionIf we share an offline page onto a device, then open it from ADM into Chrome, and try to share it with the ... menu and choose "sharing...", the attempt to share the file fails. The problem is that the offline page item on the Java side does not have either a URL or a file path. We can fix this by using the content URI that the page was shared with.
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0332c0d48dcc7cf10808c17dee986bcf4583306e commit 0332c0d48dcc7cf10808c17dee986bcf4583306e Author: Pete Williamson <petewil@chromium.org> Date: Thu Mar 22 16:54:46 2018 Pass through content URI when we have one. Sometimes offline pages are displayed from a content URI instead of opening a file from our offline page store. The user might then press the "share" menu. When they do, we should use the content URI to share the page by instead of using a file path (since we have no file path). This change will pass back the content URI instead of just disabling sharing. Unit tests are included. Bug: 817608 Change-Id: I1d788a83de3aafe978b37374ec22d77ad328b59d Reviewed-on: https://chromium-review.googlesource.com/962990 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#545115} [modify] https://crrev.com/0332c0d48dcc7cf10808c17dee986bcf4583306e/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/0332c0d48dcc7cf10808c17dee986bcf4583306e/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
,
Mar 22 2018
Repro steps: Note that you need to be on marshmallow or below for the repro steps to work. |
||
►
Sign in to add a comment |
||
Comment 1 by dewittj@chromium.org
, Mar 7 2018Status: Assigned (was: Untriaged)