New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817603 link

Starred by 1 user
Status: Fixed
Owner:
odejesush@chromium.org
Closed: Mar 2018
Cc:
reillyg@chromium.org
█ cco3@chromium.org
█ ortuno@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task

Blocking:
issue 719826



Sign in to add a comment

bluetooth: Create typemap for ScanRecord service_data field

Project Member Reported by odejesush@chromium.org, Feb 28 2018 
We need to create a typemap for the service_data map in the ScanRecord structure in fake_bluetooth.mojom so that it can convert the string key values into proper BluetoothUUIDs for use in a device::BluetoothDevice::ServiceDataMap.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/902cafd99a46587d876da2743bf6a102e3519c2d

commit 902cafd99a46587d876da2743bf6a102e3519c2d
Author: Ovidio Henriquez <odejesush@chromium.org>
Date: Sat Mar 10 06:19:09 2018

bluetooth: Handle UUIDs in service data

Adds a Mojo typemap to properly handle the UUID strings in
the service_data field of ScanRecord. The typemap allows the
service_data field to map to a device::BluetoothDevice::ServiceDataMap
object in C++.

BUG= 817603 

Change-Id: Ie4d5785e8b04098fda76ca8bc99c58141c9b5b82
Reviewed-on: https://chromium-review.googlesource.com/942307
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542344}
[modify] https://crrev.com/902cafd99a46587d876da2743bf6a102e3519c2d/device/bluetooth/public/mojom/test/OWNERS
[modify] https://crrev.com/902cafd99a46587d876da2743bf6a102e3519c2d/device/bluetooth/public/mojom/test/fake_bluetooth.mojom
[add] https://crrev.com/902cafd99a46587d876da2743bf6a102e3519c2d/device/bluetooth/public/mojom/test/fake_bluetooth.typemap
[add] https://crrev.com/902cafd99a46587d876da2743bf6a102e3519c2d/device/bluetooth/public/mojom/test/fake_bluetooth_mojom_traits.h
[add] https://crrev.com/902cafd99a46587d876da2743bf6a102e3519c2d/device/bluetooth/public/mojom/test/typemaps.gni
[modify] https://crrev.com/902cafd99a46587d876da2743bf6a102e3519c2d/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/902cafd99a46587d876da2743bf6a102e3519c2d/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/902cafd99a46587d876da2743bf6a102e3519c2d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html
[modify] https://crrev.com/902cafd99a46587d876da2743bf6a102e3519c2d/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/fake_bluetooth.mojom.js
[modify] https://crrev.com/902cafd99a46587d876da2743bf6a102e3519c2d/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/web-bluetooth-test.js

Comment 2 by odejesush@chromium.org, Mar 12 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment