New issue
Advanced search Search tips

Issue 817601 link

Starred by 0 users
Status: Fixed
Owner:
khushals...@chromium.org
Closed: Mar 2018
Cc:
eseckler@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Don't trigger impl-side invalidations for animate_only BeginFrames.

Project Member Reported by khushals...@chromium.org, Feb 28 2018 
If a BeginFrame is animate_only, it does not need visual output and gets aborted after blink's lifecycle updates until layout. We shouldn't be triggering CompositorFrames from impl-side invalidations in these cases too.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5301b93eeafbc21fa079b08b016eeab3b1411a48

commit 5301b93eeafbc21fa079b08b016eeab3b1411a48
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Mar 01 04:23:50 2018

cc: No impl-side invalidations for animate_only BeginFrames.

If the BeginFrame was animate_only, it does not need visual output so
avoid performing unnecessary invalidations.

R=brianderson@chromium.org, eseckler@chromium.org

BUG:  817601 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I974fd21ae6db7931972cd2b7742605d51ca63716
Reviewed-on: https://chromium-review.googlesource.com/942038
Reviewed-by: Brian Anderson <brianderson@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540045}
[modify] https://crrev.com/5301b93eeafbc21fa079b08b016eeab3b1411a48/cc/scheduler/scheduler.cc
[modify] https://crrev.com/5301b93eeafbc21fa079b08b016eeab3b1411a48/cc/scheduler/scheduler_state_machine.cc
[modify] https://crrev.com/5301b93eeafbc21fa079b08b016eeab3b1411a48/cc/scheduler/scheduler_state_machine.h
[modify] https://crrev.com/5301b93eeafbc21fa079b08b016eeab3b1411a48/cc/scheduler/scheduler_state_machine_unittest.cc
[modify] https://crrev.com/5301b93eeafbc21fa079b08b016eeab3b1411a48/cc/scheduler/scheduler_unittest.cc

Comment 2 by khushals...@chromium.org, Mar 1 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment