New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817598 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 726619



Sign in to add a comment

[PIP] Browser crashes when PIP contextual menu item selected.

Project Member Reported by apaci...@chromium.org, Feb 28 2018

Issue description

The PIP controller attempts to show the window without its initialization.

Since we're focusing on the media controls entry point at the moment, we should temporarily do nothing from the contextual menu.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21715f31b594a60d4dccc97866039332cc12ef2e

commit 21715f31b594a60d4dccc97866039332cc12ef2e
Author: Jennifer Apacible <apacible@chromium.org>
Date: Thu Mar 01 19:23:10 2018

[Picture in Picture] Disable context menu PIP command.

This is temporary while PIP is being wired up and worked to be more
stable through the media controls entry point.

The menu item is not removed because we intend to continue using it
and it is currently hidden behind a flag.

BUG:  817598 
Change-Id: I9156d81b40dd6c97e19c6eef3f5fbbe13e350639
Reviewed-on: https://chromium-review.googlesource.com/942305
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540246}
[modify] https://crrev.com/21715f31b594a60d4dccc97866039332cc12ef2e/chrome/browser/renderer_context_menu/render_view_context_menu.cc

Cc: fbeaufort@chromium.org
+fbeaufort@ who said he would have a look at this.
Cc: mlamouri@chromium.org
Status: Fixed (was: Started)
Blocking: 726619
Components: Blink>Media>PictureInPicture

Comment 8 by minch@chromium.org, May 10 2018

Hi, I am going to work on PIP in ChromeOS. I tried to find multiple videos in chrome browser but found "Picture-in-Picture" item in the context menu is disabled. It should because the cl https://chromium-review.googlesource.com/950945 added a restriction. Is there any chance that how can I make the restriction happy and then enable the "Picture-in-Picture" in the context menu?

I just want to try to test it in my own device and see whether I can start to do sth in ChromeOS part. Thanks.
You can play with this Chrome Extension that demonstrates the Picture-in-Picture API in Chrome: https://github.com/beaufortfrancois/picture-in-picture-chrome-extension

Sign in to add a comment