New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817593 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

network-settings config: Policy provided openvpn does not set OpenVPN.Password

Project Member Reported by steve...@chromium.org, Feb 28 2018

Issue description

1. Sign in to an account with a policy provided OpenVPN configuration.
2. Attempt to connect to the vpn from the UI, enter username, password, and OTP
3. Observe: VPN fails to connect.

Note: In chrome://device-log, OpenVPN.User / Password / OTP are not set in SetProperty.

The old UI set Shill properties directly. The new UI goes through the managed ONC code which validates properties. I suspect this is where the bug lies.

 
Rather than attempting to fix this for 65, I plan to disable the Settings based network config for 65 and fix this for 66 instead.

Labels: Merge-Request-65
Uploaded https://chromium-review.googlesource.com/c/chromium/src/+/942341

Setting 'merge request' even though the change is 65 specific.

Project Member

Comment 3 by sheriffbot@chromium.org, Mar 1 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: We are only 4 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 1 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fab3288ad8c824b48cb390537b2c5cd900ee11af

commit fab3288ad8c824b48cb390537b2c5cd900ee11af
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Mar 01 00:28:39 2018

Disable network-settings-config by default

This includes a minor change to fix a case that was missed when
the new UI is not enabled.

Bug:  817593 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I63cc277efed024f388e9f45fc196006602e8b757
Reviewed-on: https://chromium-review.googlesource.com/942341
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#633}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/fab3288ad8c824b48cb390537b2c5cd900ee11af/chrome/browser/about_flags.cc
[modify] https://crrev.com/fab3288ad8c824b48cb390537b2c5cd900ee11af/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/fab3288ad8c824b48cb390537b2c5cd900ee11af/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/fab3288ad8c824b48cb390537b2c5cd900ee11af/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/fab3288ad8c824b48cb390537b2c5cd900ee11af/chromeos/chromeos_switches.cc
[modify] https://crrev.com/fab3288ad8c824b48cb390537b2c5cd900ee11af/chromeos/chromeos_switches.h

Status: Fixed (was: Started)

Sign in to add a comment