New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817591 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Modern Media Controls: Remove time popup during scrubbing

Project Member Reported by steimel@chromium.org, Feb 28 2018

Issue description

Per new mocks, we are no longer going to have the current time bubble during scrubbing. Instead, the time stamp and other remaining controls will now stay visible

https://docs.google.com/presentation/d/1Xwu6nvCoxEIjuIdGYt9DRPBHqEX3QQkpQluHcJazCsE/edit#slide=id.g31148197c4_0_2

https://drive.google.com/open?id=172BO205BaaIVXQWH0-KSCs3wSEgvsTmv&authuser=amyroberts@google.com)
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9e6260a774e51d94904e4427fa4747434e454e3

commit b9e6260a774e51d94904e4427fa4747434e454e3
Author: Tommy Steimel <steimel@chromium.org>
Date: Fri Mar 16 17:25:36 2018

Remove current time popup during scrubbing on the modern media controls

This CL removes the code that created the current time scrubbing popup
in the modern media controls. It also changes the CSS to show the
button panel during scrubbing.

Bug:  817591 , 816442
Change-Id: I8ad2bd5a634f0706884ca6648a36f506af620c23
Reviewed-on: https://chromium-review.googlesource.com/964904
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543746}
[modify] https://crrev.com/b9e6260a774e51d94904e4427fa4747434e454e3/third_party/WebKit/LayoutTests/media/controls/modern/scrubbing-touch.html
[modify] https://crrev.com/b9e6260a774e51d94904e4427fa4747434e454e3/third_party/WebKit/LayoutTests/media/controls/modern/scrubbing.html
[modify] https://crrev.com/b9e6260a774e51d94904e4427fa4747434e454e3/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/b9e6260a774e51d94904e4427fa4747434e454e3/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
[modify] https://crrev.com/b9e6260a774e51d94904e4427fa4747434e454e3/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h
[modify] https://crrev.com/b9e6260a774e51d94904e4427fa4747434e454e3/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css

Status: Fixed (was: Started)
Cc: beccahughes@chromium.org steimel@chromium.org hbengali@chromium.org
 Issue 827561  has been merged into this issue.

Sign in to add a comment