[Remoting Mobile] Refactoring ChromotingSession |
||
Issue descriptionChromotingSession is a super class that does multiple things and receives calls from both UI and network thread. Some of its components becomes invalidated after the session is disconnected, while others are valid until the session object is destroyed. This makes memory management very painful and error-prone.
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35a5c82faf8e96fb224d1b20bada488d96a2a7ad commit 35a5c82faf8e96fb224d1b20bada488d96a2a7ad Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Mar 22 00:19:29 2018 [Remoting Mobile] Rename ChromotingSession::ProvideSecret This method doesn't use the PIN. This CL renames this method to RequestPairing. Bug: 817566 Change-Id: I50cc8da936ae7242c2f227e8b4f78f013f26f6b1 Reviewed-on: https://chromium-review.googlesource.com/974461 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#544917} [modify] https://crrev.com/35a5c82faf8e96fb224d1b20bada488d96a2a7ad/remoting/client/chromoting_session.cc [modify] https://crrev.com/35a5c82faf8e96fb224d1b20bada488d96a2a7ad/remoting/client/chromoting_session.h [modify] https://crrev.com/35a5c82faf8e96fb224d1b20bada488d96a2a7ad/remoting/client/jni/jni_client.cc [modify] https://crrev.com/35a5c82faf8e96fb224d1b20bada488d96a2a7ad/remoting/ios/session/remoting_client.mm
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5d9939ec98d7c714fc9c95e0a35f08ce71ec035 commit e5d9939ec98d7c714fc9c95e0a35f08ce71ec035 Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Mar 22 02:33:31 2018 [Remoting Mobile] Remove unused weak_ptr from ChromotingSession The weak_ptr_ in ChromotingSession seems to be unused. This CL removes it. Bug: 817566 Change-Id: I4f07be8e8047b76ce36f5fe658b17bf6cf45ec72 Reviewed-on: https://chromium-review.googlesource.com/974563 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#544956} [modify] https://crrev.com/e5d9939ec98d7c714fc9c95e0a35f08ce71ec035/remoting/client/chromoting_session.cc [modify] https://crrev.com/e5d9939ec98d7c714fc9c95e0a35f08ce71ec035/remoting/client/chromoting_session.h
,
Aug 10
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 20 2018