New issue
Advanced search Search tips

Issue 817559 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
billorr@chromium.org
cassew@chromium.org
tiborg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR metrics are not collected on new page tab

Project Member Reported by offenwanger@chromium.org, Feb 28 2018 
In vr metrics shell, if the browser is on new tab page, !GetNonNativePageWebContents() is true the metrics_helper gets set to nullptr. Consequently metrics for that page, including started voice searches, do not get logged. 

https://cs.chromium.org/chromium/src/chrome/browser/android/vr/vr_shell.cc?q=VrMetricsHelper&sq=package:chromium&l=219

Comment 1 by offenwanger@chromium.org, Feb 28 2018 

This needs to be verified by someone more familiar with that code.

Comment 2 by tiborg@chromium.org, Mar 1 2018

Labels: VR-metrics

Comment 3 by yfried...@chromium.org, Mar 2 2018

Labels: Hotlist-VRB-MVP

Comment 4 by cjgrant@chromium.org, Mar 6 2018

Status: Available (was: Untriaged)

Comment 5 by ericde@google.com, Mar 6 2018

Labels: -M-67 -Hotlist-VRB-MVP M-68 Hotlist-VRB-MVP-Next
moving to MVP-NEXT after discussion w/gordonbrander@

Comment 6 Deleted

Comment 7 by offenwanger@chromium.org, Mar 9 2018 

This could cause sessions that start on one page, navigate to the new tab page (possibly by use of the back button), and navigate on from there to be logged as two shorter sessions.

Comment 8 by offenwanger@chromium.org, Mar 9 2018

Summary: VR metrics are not collected on new page tab (was: VR Voice Search metrics being missing on new tab page)

Comment 9 by mthiesse@chromium.org, May 28 2018

Labels: -M-68 M-69

Comment 10 by btebbs@chromium.org, Jul 4

Components: Internals>XR

Comment 11 by mthiesse@chromium.org, Jul 5

Labels: VRB-Next-Triage

Comment 12 by efoo@chromium.org, Aug 7 

Removing Internals>VR component and assigning to Internals>XR

Comment 13 by efoo@chromium.org, Aug 7

Components: -Internals>VR

Comment 14 by ddorwin@chromium.org, Aug 10

Cc: tiborg@chromium.org billorr@chromium.org
Components: UI>Browser>VR
 Issue 684661  tracks a more general issue regarding multiple tabs.

Comment 15 by samdrazin@chromium.org, Today (17 hours ago)

Cc: cassew@chromium.org
Labels: -M-69
►

Sign in to add a comment