New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817557 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Maximize an arc app window and at the same time enter overview mode makes the UI corrupted

Project Member Reported by x...@chromium.org, Feb 28 2018

Issue description

What steps will reproduce the problem?
(1) Open an Arc app window in normal state
(2) Maximized it and at the same time press F5 to enter overview

Expected:
The window shows correctly in overview mode

Actual result:
UI is corrupted


 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30048681898250b814d7aff35b3d2d93fefb26c1

commit 30048681898250b814d7aff35b3d2d93fefb26c1
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Fri Mar 02 00:53:36 2018

Cros splitscreen: Ignore the window bounds change transition transform if the window is in overview mode.

Bug:  817557 
Change-Id: Ibb1a048261a97fb9265e9b4330b3bbf9f21a65c8
Reviewed-on: https://chromium-review.googlesource.com/942090
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540386}
[modify] https://crrev.com/30048681898250b814d7aff35b3d2d93fefb26c1/ash/wm/window_animations_unittest.cc
[modify] https://crrev.com/30048681898250b814d7aff35b3d2d93fefb26c1/ash/wm/window_state.cc

Comment 2 by x...@chromium.org, Mar 2 2018

Cc: skuhne@chromium.org
With the fix in #1, the UI looks less broken, see the before-the-fix and after-the-fix screenshots. 

However, even with the fix, it looks like part of the Arc app window does not render correctly. The issue doesn't happen for Chrome browsers/apps window though.
before-the-fix.png
1.5 MB View Download
after-the-fix.png
1.9 MB View Download

Comment 3 by x...@chromium.org, Mar 2 2018

Labels: Merge-Request-66
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 3 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 5 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/548da54834321c23725610961e1a232764160e70

commit 548da54834321c23725610961e1a232764160e70
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Mar 05 07:00:44 2018

[Merge to M66] Cros splitscreen: Ignore the window bounds change transition transform if the window is in overview mode.

TBR=oshima@chromium.org
(cherry picked from commit 30048681898250b814d7aff35b3d2d93fefb26c1)

Bug:  817557 
Change-Id: Ibb1a048261a97fb9265e9b4330b3bbf9f21a65c8
Reviewed-on: https://chromium-review.googlesource.com/942090
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540386}
Reviewed-on: https://chromium-review.googlesource.com/947926
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#10}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/548da54834321c23725610961e1a232764160e70/ash/wm/window_animations_unittest.cc
[modify] https://crrev.com/548da54834321c23725610961e1a232764160e70/ash/wm/window_state.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71efa62ae94340a4eb92cc6e5f1e6786809b141e

commit 71efa62ae94340a4eb92cc6e5f1e6786809b141e
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Mar 05 22:02:25 2018

Cros splitscreen: Use window transform during resizing.

It's possible that during resizing, the desired resizing bounds for the snapped window is smaller
then the minimum bounds. In this case, we use window transform to apply a translation on the window
to make it visaully be placed outside of the workspace area. The transform will be reset after the
resizing.

Bug: 725683,  817557 
Change-Id: I9cf4056a30a417a2afe29d16fe6a8f80268d64b8
Reviewed-on: https://chromium-review.googlesource.com/944721
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540953}
[modify] https://crrev.com/71efa62ae94340a4eb92cc6e5f1e6786809b141e/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/71efa62ae94340a4eb92cc6e5f1e6786809b141e/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/71efa62ae94340a4eb92cc6e5f1e6786809b141e/ash/wm/splitview/split_view_controller_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25943c6a9e543de74b4c6ca7cdb1ba2d064df1ca

commit 25943c6a9e543de74b4c6ca7cdb1ba2d064df1ca
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Tue Mar 06 00:41:32 2018

[Merge to M66] Cros splitscreen: Use window transform during resizing.

It's possible that during resizing, the desired resizing bounds for the snapped window is smaller
then the minimum bounds. In this case, we use window transform to apply a translation on the window
to make it visaully be placed outside of the workspace area. The transform will be reset after the
resizing.

Bug: 725683,  817557 
TBR=oshima@chromium.org

(cherry picked from commit 71efa62ae94340a4eb92cc6e5f1e6786809b141e)

Change-Id: I9cf4056a30a417a2afe29d16fe6a8f80268d64b8
Reviewed-on: https://chromium-review.googlesource.com/944721
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540953}
Reviewed-on: https://chromium-review.googlesource.com/950005
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#24}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/25943c6a9e543de74b4c6ca7cdb1ba2d064df1ca/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/25943c6a9e543de74b4c6ca7cdb1ba2d064df1ca/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/25943c6a9e543de74b4c6ca7cdb1ba2d064df1ca/ash/wm/splitview/split_view_controller_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99346eaf452e11400555b3901e892c76f5534372

commit 99346eaf452e11400555b3901e892c76f5534372
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Tue Mar 27 22:05:08 2018

Cros splitscreen: Fix the Arc app window bounds in overview.

When Arc app window bounds are changed while it's in overview mode, we
should make sure the bounds are correctly updated.

Bug:  817557 
Change-Id: If3bb9e331f25f5b7c9f9e750ab1b3d3ae2d49e96
Reviewed-on: https://chromium-review.googlesource.com/982272
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546285}
[modify] https://crrev.com/99346eaf452e11400555b3901e892c76f5534372/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/99346eaf452e11400555b3901e892c76f5534372/ash/frame/custom_frame_view_ash.h
[modify] https://crrev.com/99346eaf452e11400555b3901e892c76f5534372/components/exo/shell_surface_base.cc

Comment 9 by x...@chromium.org, Mar 27 2018

Status: Fixed (was: Assigned)

Sign in to add a comment