New issue
Advanced search Search tips

Issue 817546 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 807029



Sign in to add a comment

cros buildresult requires all tryjobs to be in CIDB.

Project Member Reported by dgarr...@chromium.org, Feb 28 2018

Issue description

The "cros buildresult" command uses CIDB entries to report on the state of a given build. That doesn't work for tryjobs in Debug CIDB.

 
Blocking: 807029
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e1d79146dcc25f17b09db05957d5c3a23d761d45

commit e1d79146dcc25f17b09db05957d5c3a23d761d45
Author: Don Garrett <dgarrett@google.com>
Date: Fri Mar 02 03:13:05 2018

cbuildbot_config: Add debug-cidb option.

Add a new build config value that forces a build config to use Debug
CIDB instead of Prod CIDB, and set it for assorted tryjobs that are
unsafe if run against Prod CIDB.

BUG= chromium:817546 
TEST=run_tests

Change-Id: I05b2f5d4062084fd84e7583db782f763f6700e0a
Reviewed-on: https://chromium-review.googlesource.com/942048
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/e1d79146dcc25f17b09db05957d5c3a23d761d45/cbuildbot/config_dump.json
[modify] https://crrev.com/e1d79146dcc25f17b09db05957d5c3a23d761d45/scripts/cbuildbot.py
[modify] https://crrev.com/e1d79146dcc25f17b09db05957d5c3a23d761d45/lib/config_lib.py
[modify] https://crrev.com/e1d79146dcc25f17b09db05957d5c3a23d761d45/cbuildbot/chromeos_config.py

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a90f0147179a9aaa4e5500e5722ae0dc4dbf9d2a

commit a90f0147179a9aaa4e5500e5722ae0dc4dbf9d2a
Author: Don Garrett <dgarrett@google.com>
Date: Fri Mar 02 03:13:03 2018

cbuildbot: Add --debug-cidb.

Add a new command line option to force a build to use the Debug
instance of CIDB. It's intended for advanced build infrastructure
testing that could otherwise interfere with production builds.

BUG= chromium:817546 
TEST=run_tests

Change-Id: I6977128010cf175841c1cbf7329841fc0d2be5aa
Reviewed-on: https://chromium-review.googlesource.com/942096
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/a90f0147179a9aaa4e5500e5722ae0dc4dbf9d2a/scripts/cbuildbot.py
[modify] https://crrev.com/a90f0147179a9aaa4e5500e5722ae0dc4dbf9d2a/cli/cros/cros_tryjob_unittest.py
[modify] https://crrev.com/a90f0147179a9aaa4e5500e5722ae0dc4dbf9d2a/cli/cros/cros_tryjob.py

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/63765c4eb05ecf3c56eb1a0f6117b37956b1da91

commit 63765c4eb05ecf3c56eb1a0f6117b37956b1da91
Author: Don Garrett <dgarrett@google.com>
Date: Fri Mar 02 03:13:06 2018

cbuildbot: Update CIDB selection logic.

If we are on a builder, use the Prod CIDB. If we are a local build,
don't use CIDB. Allow --debug-cidb to force Debug CIDB in any
environement.

BUG= chromium:817546 
TEST=run_tests

Change-Id: I0f858515a0e7614f5f86343fb7a65808e2052fcf
Reviewed-on: https://chromium-review.googlesource.com/942097
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/63765c4eb05ecf3c56eb1a0f6117b37956b1da91/scripts/cbuildbot.py

This now true for MOST tryjobs, anything except the builds which schedule other builds.
Status: Fixed (was: Untriaged)
I'm going to call this "fixed enough".

Sign in to add a comment