supersize_archive failing on Android Perf builders |
||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of oysteine@google.com 1a339269-2fe8-4f0b-96b0-89fbc30a4ff9 Builders failed on: - Android Builder: https://build.chromium.org/p/chromium.perf/builders/Android%20Builder - Android arm64 Builder: https://build.chromium.org/p/chromium.perf/builders/Android%20arm64%20Builder
,
Feb 28 2018
Issue 817533 has been merged into this issue.
,
Feb 28 2018
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b70a4435f46b08b4e5b19a0793a87a99f28045d commit 9b70a4435f46b08b4e5b19a0793a87a99f28045d Author: Peter Wen <wnwen@chromium.org> Date: Thu Mar 01 01:26:14 2018 Revert "Supersize: Fix pak spurious deltas" This reverts commit 6d411ef0a77d65ece6166fd5c411983a8548f467. Reason for revert: Failed perf builders with division by zero Original change's description: > Supersize: Fix pak spurious deltas > > Previously we recorded the exact pak compression ratios in .size files. > This results in minor changes to 1k+ unrelated symbols due to changes in > compression. Use a mostly accurate static constant instead to make .size > files comparable across runs. > > Bug: 814078 > Change-Id: I63c78379898ef02885ae86e0b95df95d51965918 > Reviewed-on: https://chromium-review.googlesource.com/938122 > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539252} TBR=wnwen@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 814078 , 817534 Change-Id: I5cd4a6375e1f318c3559801da95a850f5ffcf4fa Reviewed-on: https://chromium-review.googlesource.com/942061 Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539971} [modify] https://crrev.com/9b70a4435f46b08b4e5b19a0793a87a99f28045d/tools/binary_size/libsupersize/archive.py
,
Mar 1 2018
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6e318dcf7f158e1f019462aa26151a25869ac93 commit d6e318dcf7f158e1f019462aa26151a25869ac93 Author: Peter Wen <wnwen@chromium.org> Date: Thu Mar 01 15:27:57 2018 Reland "Supersize: Fix pak spurious deltas" Original CL: https://crrev.com/c/938122 Fix: - Division by zero when there is no uncompressed pak files. TBR=agrieve@chromium.org Bug: 814078 , 817534 Change-Id: Id3198a84dce95074d13ca20afe4caec45631b0cc Reviewed-on: https://chromium-review.googlesource.com/943221 Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540161} [modify] https://crrev.com/d6e318dcf7f158e1f019462aa26151a25869ac93/tools/binary_size/libsupersize/archive.py |
||
►
Sign in to add a comment |
||
Comment 1 by oysteine@chromium.org
, Feb 28 2018