New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817534 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

supersize_archive failing on Android Perf builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Feb 28 2018

Issue description

Owner: wnwen@chromium.org
wnwenb@: This seems likely to be due to https://chromium-review.googlesource.com/938122

W     47 This script runs more than 2x faster if you install pypy.
I     52 Using --tool-prefix=/b/build/slave/Android_arm64_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/llvm-
I     52 Using --output-directory=src/out/Release
I     70 Parsing ninja files.
I  11454 Parsing Linker Map
I  15566 Demangling 447951 values
I  19144 Stripping linker prefixes from symbol names
nm: I  19407 Demangling 649562 keys
I  19487 Demangling 513 symbols
I  19500 * Failed to demangle 513/513 items
I  19500 Adding symbols removed by identical code folding (as reported by nm)
W  26103 Name missing from aliases:  ['armSP_FFTFwd_CToC_FC32_Radix2_fs_OutOfPlace', 'armSP_FFTInv_CToC_FC32_Radix2_fs_OutOfPlace']
nm: I  29693 * Failed to demangle 516/649562 items
nm: I  31857 * 674457 keys become 624391 keys
I  36950 Creating aliases for symbols shared by multiple paths
I  40201 Waiting for string literal extraction to complete.
I  40202 Deconstructing ** merge strings into literals
Traceback (most recent call last):
  File "/b/build/slave/Android_arm64_Builder/build/src/tools/binary_size/libsupersize/main.py", line 114, in <module>
    main()
  File "/b/build/slave/Android_arm64_Builder/build/src/tools/binary_size/libsupersize/main.py", line 110, in main
    args.func(args, parser)
  File "/b/build/slave/Android_arm64_Builder/build/src/tools/binary_size/libsupersize/archive.py", line 1131, in Run
    pak_files=args.pak_file, pak_info_file=args.pak_info_file)
  File "/b/build/slave/Android_arm64_Builder/build/src/tools/binary_size/libsupersize/archive.py", line 897, in CreateSectionSizesAndSymbols
    pak_symbols_by_id = _FindPakSymbolsFromApk(apk_path, output_directory)
  File "/b/build/slave/Android_arm64_Builder/build/src/tools/binary_size/libsupersize/archive.py", line 829, in _FindPakSymbolsFromApk
    float(total_compressed_size) / total_uncompressed_size)
ZeroDivisionError: float division by zero
step returned non-zero exit code: 1
 Issue 817533  has been merged into this issue.

Comment 3 by wnwen@chromium.org, Feb 28 2018

Labels: OS-Android
Reverting: https://crrev.com/c/942061

Will reland with a fix.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b70a4435f46b08b4e5b19a0793a87a99f28045d

commit 9b70a4435f46b08b4e5b19a0793a87a99f28045d
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Mar 01 01:26:14 2018

Revert "Supersize: Fix pak spurious deltas"

This reverts commit 6d411ef0a77d65ece6166fd5c411983a8548f467.

Reason for revert: Failed perf builders with division by zero

Original change's description:
> Supersize: Fix pak spurious deltas
> 
> Previously we recorded the exact pak compression ratios in .size files.
> This results in minor changes to 1k+ unrelated symbols due to changes in
> compression. Use a mostly accurate static constant instead to make .size
> files comparable across runs.
> 
> Bug:  814078 
> Change-Id: I63c78379898ef02885ae86e0b95df95d51965918
> Reviewed-on: https://chromium-review.googlesource.com/938122
> Reviewed-by: agrieve <agrieve@chromium.org>
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539252}

TBR=wnwen@chromium.org,agrieve@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  814078 , 817534 
Change-Id: I5cd4a6375e1f318c3559801da95a850f5ffcf4fa
Reviewed-on: https://chromium-review.googlesource.com/942061
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539971}
[modify] https://crrev.com/9b70a4435f46b08b4e5b19a0793a87a99f28045d/tools/binary_size/libsupersize/archive.py

Comment 5 by wnwen@chromium.org, Mar 1 2018

Status: Fixed (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6e318dcf7f158e1f019462aa26151a25869ac93

commit d6e318dcf7f158e1f019462aa26151a25869ac93
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Mar 01 15:27:57 2018

Reland "Supersize: Fix pak spurious deltas"

Original CL: https://crrev.com/c/938122

Fix:
- Division by zero when there is no uncompressed pak files.

TBR=agrieve@chromium.org

Bug:  814078 , 817534 
Change-Id: Id3198a84dce95074d13ca20afe4caec45631b0cc
Reviewed-on: https://chromium-review.googlesource.com/943221
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540161}
[modify] https://crrev.com/d6e318dcf7f158e1f019462aa26151a25869ac93/tools/binary_size/libsupersize/archive.py

Sign in to add a comment