Check if builders have xattr / fallocate |
|||||||
Issue descriptionI need to figure out if builders have xattr / fallocate support. This is needed for some tests in UE. It would be nice to do a simple following test on one -c2 and one -m builders: cd /tmp touch foo setfattr -n user.xattr-test -v value foo getfattr foo if none of those show errors (and the last should show something like "user.xattr-test"), then it should be good to go.
,
May 8 2018
This is an ancient request that I dropped to the floor. Do we still need this (likely you got someone else to check / found a workaround already?)
,
May 8 2018
i wouldn't say 2 months is ancient ... i think he's just not committed the tests, so we'd still like this info
,
May 8 2018
Yes please. we still need this if possible. It was not urgent, but eventually I would like to know the answer in order to cleanup some code. Thank you,
,
May 10 2018
Please, feel free to assign to someone else if possible. Thanks.
,
May 11 2018
Re #3, ancient by standards of "I'm blocked on this" :) Anyway: for GCE builders: pprabhu@cros-beefy105-c2:/tmp$ setfattr -n user.xattr-test -v value foo The program 'setfattr' is currently not installed. To run 'setfattr' please ask your administrator to install the p ackage 'attr' pprabhu@cros-beefy105-c2:/tmp$ getfattr foo The program 'getfattr' is currently not installed. To run 'getfattr' please ask your administrator to install the p ackage 'attr' for baremetal (golo) builders: chrome-bot@build4-m2:(Linux 14.04):/tmp$ setfattr -n user.xattr-test -v value foo The program 'setfattr' is currently not installed. To run 'setfattr' please ask your administrator to install the package 'attr' [127] chrome-bot@build4-m2:(Linux 14.04):/tmp$ getfattr foo The program 'getfattr' is currently not installed. To run 'getfattr' please ask your administrator to install the package 'attr' ------ You will have to get the (new) CI team to install this on builders.
,
May 14 2018
Installing this is a lot of work to just clean up the code. I'm going to say that this doesn't rise to the level of criticality that we would need to see to justify doing all of that work.
,
May 14 2018
It is totally understandable. It wasn't that critical and it is good to know that we still don't have support yet. Thanks for the update.
,
May 15 2018
we weren't requesting the package be installed for all builders. that was just the easiest way to assess functionality. the goal here is to get test coverage for AU code that is run on release images. that seems like a fairly important thing to support. i guess on the AU side, the unittest could just do its own feature testing in the unittest ... try to set an attribute in a way that is supposed to work, and if it fails with ENOTSUP or whatever, just SKIP the test in question. i think gtest fixtures make this possible: https://android.googlesource.com/platform/external/minijail/+/780aef7ec4b725fdffa634dd58773982bbd9b142%5E%21/#F1
,
May 15 2018
,
May 15 2018
I think that was what we are doing. A while ago some changes in Android broke some code because the unit tests were skipped because Android does't have /tmp. The skip for such tests were added here: https://chromium-review.googlesource.com/c/chromiumos/platform/update_engine/+/170782 Currently, these tests are still being skipped in both Android and Chrome OS I believe. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ahass...@chromium.org
, Mar 30 2018