New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817507 link

Starred by 1 user
Status: Fixed
Owner:
haddowk@chromium.org
Closed: Mar 2018
Cc:
█ mattmallett@chromium.org
pprabhu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Ensure that the dhcp server never starts on the same subnet as the external interface

Project Member Reported by haddowk@chromium.org, Feb 28 2018 

For reasons that are not fully understood, the moblab booted with one ethernet interface having an ip address of 192.168.231.150 and the other being blank.

This caused the detection code to set 192.168.231.150 as the external network and start a bridge/dhcp server on the 192.168.231.1 network.

This causes the lab network to have multiple DHCP server and our network port gets shut down.

Exclude 192.168.231.* being set as the external network, that subnet range should only be internal.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/1f4b18f3f2c94b293b21d32278a697f3e9a1a022

commit 1f4b18f3f2c94b293b21d32278a697f3e9a1a022
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Mar 02 00:13:44 2018

[moblab] Ignore server net range when detecting external ip

When detecting which network interface is external and which is
internal it has been observed in rare cases the external IP
address is not assigned, but the internal IP address is being
returned, the logic then setup an incorrect bridge and results
in a DHCP server being started on the external network connection.

BUG= chromium:817507 
TEST=build and test on moblab

Change-Id: I2396603fad2a09e368e8ca3a450baf486495d9c6
Reviewed-on: https://chromium-review.googlesource.com/943821
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/1f4b18f3f2c94b293b21d32278a697f3e9a1a022/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-network-bridge-init.conf

Comment 2 by haddowk@chromium.org, Mar 2 2018

Status: Fixed (was: Started)
►

Sign in to add a comment