The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e470357360010d7de465b33650a040a9471b93f6

commit e470357360010d7de465b33650a040a9471b93f6
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Mar 01 16:08:50 2018

Uprev the NTDDI version to Windows 10 RS1

The InputPane APIs first appeared in RS1 version. RS2 or later SDK
is required to build Chrome so changing the version shouldn't be a
problem.

BUG= 817501 

Change-Id: I1ed1f4a630ffe1d913dee47c03ad4fd45f3c6759
Reviewed-on: https://chromium-review.googlesource.com/941913
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540172}
[modify] https://crrev.com/e470357360010d7de465b33650a040a9471b93f6/build/config/win/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9d1cede7c4eaef1d5adf19c87cc4dbd232efbb8

commit d9d1cede7c4eaef1d5adf19c87cc4dbd232efbb8
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Mar 01 19:15:29 2018

Clone osk_display_manager.h/cc to on_screen_keyboard_display_manager_tab_tip

For ease of review copy the files over. A follow up patch
(https://chromium-review.googlesource.com/c/chromium/src/+/941911) will be
made to actually change the implementation. Presubmit skipped so this is
exactly just a copy file otherwise it errors out on the banned functions
used in this file. (Fixed in followup)

BUG= 817501 
NOPRESUBMIT=true

Change-Id: I71caaca96f8b722717632d32f8c4187fc0ebaf7d
Reviewed-on: https://chromium-review.googlesource.com/943342
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540243}
[add] https://crrev.com/d9d1cede7c4eaef1d5adf19c87cc4dbd232efbb8/ui/base/win/on_screen_keyboard_display_manager_tab_tip.cc
[add] https://crrev.com/d9d1cede7c4eaef1d5adf19c87cc4dbd232efbb8/ui/base/win/on_screen_keyboard_display_manager_tab_tip.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df426e1e31aade79c9b42a2ed07a54da125f9b5b

commit df426e1e31aade79c9b42a2ed07a54da125f9b5b
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Mar 02 22:37:35 2018

Abstract OnScreenKeyboardDisplayManager into a pure virtual class.

In order to facilitate improving the virtual keyboard experience on
Windows 10 RS1 separate the OnScreenKeyboardDisplayManager
interface into a stub impl (that is used on devices less than Windows 8)
and the tab tip impl (that is used on Windows 8 and above). A follow-up
patch will introduce a new version that will use InputPane on Windows 10
RS1 and later.

BUG= 817501 

Change-Id: Ib8c626d12e7014551af54c2b5d4d047d2ca2505b
Reviewed-on: https://chromium-review.googlesource.com/941911
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540666}
[modify] https://crrev.com/df426e1e31aade79c9b42a2ed07a54da125f9b5b/ui/base/BUILD.gn
[add] https://crrev.com/df426e1e31aade79c9b42a2ed07a54da125f9b5b/ui/base/win/on_screen_keyboard_display_manager_stub.cc
[add] https://crrev.com/df426e1e31aade79c9b42a2ed07a54da125f9b5b/ui/base/win/on_screen_keyboard_display_manager_stub.h
[modify] https://crrev.com/df426e1e31aade79c9b42a2ed07a54da125f9b5b/ui/base/win/on_screen_keyboard_display_manager_tab_tip.cc
[modify] https://crrev.com/df426e1e31aade79c9b42a2ed07a54da125f9b5b/ui/base/win/on_screen_keyboard_display_manager_tab_tip.h
[modify] https://crrev.com/df426e1e31aade79c9b42a2ed07a54da125f9b5b/ui/base/win/osk_display_manager.cc
[modify] https://crrev.com/df426e1e31aade79c9b42a2ed07a54da125f9b5b/ui/base/win/osk_display_manager.h
[modify] https://crrev.com/df426e1e31aade79c9b42a2ed07a54da125f9b5b/ui/base/win/osk_display_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2315d8f609fd20d5233df2f57e2529753dfbaec3

commit 2315d8f609fd20d5233df2f57e2529753dfbaec3
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Mar 06 17:52:55 2018

Clean up on screen keyboard callback interface on Windows.

Change API callback interface to be in DIPs. It is much simplier to
implement that for InputPane.

Don't send the scroll into view message as that is already sent
with the SetInsets message and eliminates the query for the current
mouse cursor position to determine the touch position which is wrong.

Remove the occluded rect from the hidden callback as it isn't used.

BUG= 817501 

Change-Id: I94050ede776afcbb358d2a997ecf691bb8d1c78b
Reviewed-on: https://chromium-review.googlesource.com/949783
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541141}
[modify] https://crrev.com/2315d8f609fd20d5233df2f57e2529753dfbaec3/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/2315d8f609fd20d5233df2f57e2529753dfbaec3/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/2315d8f609fd20d5233df2f57e2529753dfbaec3/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/2315d8f609fd20d5233df2f57e2529753dfbaec3/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/2315d8f609fd20d5233df2f57e2529753dfbaec3/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/2315d8f609fd20d5233df2f57e2529753dfbaec3/content/public/browser/render_widget_host_view.h
[modify] https://crrev.com/2315d8f609fd20d5233df2f57e2529753dfbaec3/ui/base/win/on_screen_keyboard_display_manager_tab_tip.cc
[modify] https://crrev.com/2315d8f609fd20d5233df2f57e2529753dfbaec3/ui/base/win/osk_display_observer.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8349d20dbcb364461274f55b763f7c34ae463ef8

commit 8349d20dbcb364461274f55b763f7c34ae463ef8
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Mar 27 03:13:27 2018

Move files from ui/base/win/ to ui/base/ime/win.

In a followup CL osk_display_manager.* will disappear because the
OnScreenKeyboardDisplayManager implementations will be hung off the
InputMethodWinBase class so that there isn't a singleton but are associated
with a HWND.

BUG= 817501 

Change-Id: I67123d1080a32d5dc888aa996079dc7512f20ff9
Reviewed-on: https://chromium-review.googlesource.com/978462
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545941}
[modify] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/ui/base/BUILD.gn
[modify] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/ui/base/ime/BUILD.gn
[rename] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/ui/base/ime/win/on_screen_keyboard_display_manager_stub.cc
[rename] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/ui/base/ime/win/on_screen_keyboard_display_manager_stub.h
[rename] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/ui/base/ime/win/on_screen_keyboard_display_manager_tab_tip.cc
[rename] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/ui/base/ime/win/on_screen_keyboard_display_manager_tab_tip.h
[rename] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/ui/base/ime/win/on_screen_keyboard_display_manager_unittest.cc
[rename] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/ui/base/ime/win/osk_display_manager.cc
[rename] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/ui/base/ime/win/osk_display_manager.h
[rename] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/ui/base/ime/win/osk_display_observer.h
[modify] https://crrev.com/8349d20dbcb364461274f55b763f7c34ae463ef8/ui/views/controls/textfield/textfield.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92480b21ea27a4d55d2efa75e8a02200f831f771

commit 92480b21ea27a4d55d2efa75e8a02200f831f771
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed May 02 17:18:18 2018

Introduce InputMethodKeyboardController class.

Replace OnScreenKeyboardDisplayManager on Windows with the
InputMethodKeyboardController class. Do this so that there is no longer
a singleton but InputMethodKeyboardControllers are associated with the
InputMethodWinBase object. This is needed for a later change that uses
InputPane which listens to changes to the associated window handle. Using
a singleton causes a bunch of confusion with classes that need to be
associated with a HWND.

BUG= 817501 

Change-Id: I4fe8471c5eb84aa707136477c83b07cbf1acf7bb
Reviewed-on: https://chromium-review.googlesource.com/978841
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555446}
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/chrome/browser/chromeos/input_method/input_method_manager_impl.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/chrome/browser/ui/views/location_bar/keyword_hint_view.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/components/omnibox/browser/omnibox_view.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/components/omnibox/browser/omnibox_view.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/BUILD.gn
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/chromeos/input_method_manager.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/chromeos/mock_input_method_manager.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/chromeos/mock_input_method_manager.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/dummy_input_method.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/dummy_input_method.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_auralinux.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_base.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_base.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_chromeos.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_chromeos.h
[add] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_keyboard_controller.h
[add] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_keyboard_controller_observer.h
[add] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_keyboard_controller_stub.cc
[add] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_keyboard_controller_stub.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_mac.mm
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_minimal.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/input_method_win_base.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/mock_input_method.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/mock_input_method.h
[delete] https://crrev.com/8ff28db19a23e51ff6a79a01774c1370352f5a21/ui/base/ime/win/on_screen_keyboard_display_manager_stub.cc
[delete] https://crrev.com/8ff28db19a23e51ff6a79a01774c1370352f5a21/ui/base/ime/win/on_screen_keyboard_display_manager_stub.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/win/on_screen_keyboard_display_manager_tab_tip.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/win/on_screen_keyboard_display_manager_tab_tip.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/base/ime/win/on_screen_keyboard_display_manager_unittest.cc
[delete] https://crrev.com/8ff28db19a23e51ff6a79a01774c1370352f5a21/ui/base/ime/win/osk_display_manager.cc
[delete] https://crrev.com/8ff28db19a23e51ff6a79a01774c1370352f5a21/ui/base/ime/win/osk_display_manager.h
[delete] https://crrev.com/8ff28db19a23e51ff6a79a01774c1370352f5a21/ui/base/ime/win/osk_display_observer.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/92480b21ea27a4d55d2efa75e8a02200f831f771/ui/views/controls/textfield/textfield.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a692cb6fcdb41c99b25fc51bcf351bfd56f761

commit 62a692cb6fcdb41c99b25fc51bcf351bfd56f761
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed May 16 16:51:38 2018

Add support to control OSK via InputPane on Windows 10 RS1 and later.

Improve the reliability of the windows virtual keyboard by using
the InputPane class. This Windows RT API takes care of figuring out
if the keyboard should be displayed or not (ie. if a hardware keyboard
is connected, or a touchscreen connected etc.)

BUG= 817501 

Change-Id: Ie310b7f485ff4096bb4f8943d43d84dced652ac6
Reviewed-on: https://chromium-review.googlesource.com/946152
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559142}
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/BUILD.gn
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/chromeos/mock_input_method_manager.cc
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/chromeos/mock_input_method_manager.h
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/input_method_keyboard_controller.h
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/input_method_keyboard_controller_stub.cc
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/input_method_keyboard_controller_stub.h
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/input_method_win_base.cc
[add] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/win/on_screen_keyboard_display_manager_input_pane.cc
[add] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/win/on_screen_keyboard_display_manager_input_pane.h
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/win/on_screen_keyboard_display_manager_tab_tip.cc
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/win/on_screen_keyboard_display_manager_tab_tip.h
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ime/win/on_screen_keyboard_display_manager_unittest.cc
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ui_base_features.cc
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/base/ui_base_features.h
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/62a692cb6fcdb41c99b25fc51bcf351bfd56f761/ui/keyboard/keyboard_controller.h

The code is ready and works in some Windows Releases but various versions seem to give varying results. Specifically around the omnibox when you touch it. The keyboard appears on touch down but it disappears on touch up.

I've reached out to Microsoft to help give us some insight. Results thus far are:

Issues on desktop: 14393.2248 with an external touch display.

Issues on 16299.125 but appears fixed updating the same device to 16299.371 but fails after updating to 16299.431.

On a Surface Book 3 with 17672.1000 it works awesome.

May have to wait until RS5 ships? And enable it only for that platform and later?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47db9c8f168361c89fc50bc2a744d79a9fe47ab6

commit 47db9c8f168361c89fc50bc2a744d79a9fe47ab6
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Jun 08 20:37:39 2018

Adjust usage of InputPane to be Windows 10 RS4 and later.

Microsoft has confirmed there are some issues with InputPane on earlier
versions before RS4.

BUG= 817501 

Change-Id: Ifa4557ecf479e10d619a6353e28c4f8eb3684867
Reviewed-on: https://chromium-review.googlesource.com/1093266
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565731}
[modify] https://crrev.com/47db9c8f168361c89fc50bc2a744d79a9fe47ab6/ui/base/ime/input_method_win_base.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6c18518bbcc4fb0ca88aa7d11214021abad09d9

commit e6c18518bbcc4fb0ca88aa7d11214021abad09d9
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Jun 11 19:26:48 2018

Enable InputPane virtual keyboard functionality by default.

Flip feature flag on. New functionality is used for Windows 10 RS4 and
later.

BUG= 817501 

Change-Id: I3c45ac35f925a3b72f2ff50d5f8fdad4895b3cfd
Reviewed-on: https://chromium-review.googlesource.com/946928
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566102}
[modify] https://crrev.com/e6c18518bbcc4fb0ca88aa7d11214021abad09d9/ui/base/ui_base_features.cc