New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817491 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Explicit 2D intents targeting VR launcher with deep-link extra try to enter VR

Project Member Reported by dbbrooks@chromium.org, Feb 28 2018

Issue description

Chrome Version: 66.0.3356.0
OS: Android N
Device: S8+
VrCore: 1.13.185188193

What steps will reproduce the problem?
(1) enable the vr-launch-intents flag
(2) close Chrome
(3) Open any app, e.g. calculator
(4) connect phone via adb
(5) run the following command
adb shell am start -a android.intent.action.VIEW -n "com.chrome.dev/org.chromium.chrome.browser.vr.VrMainActivity" --ez android.intent.extra.VR_LAUNCH true -d www.google.com


What is the expected result? VR browsing experience launches (DON flow included)

What happens instead? A failure message appears in VR browsing, then Chrome in 2D mode appears. See attached video.

 
screen.mp4
1.7 MB View Download
Labels: M-67 Pri-1 Type-Bug
Owner: mthiesse@chromium.org
Status: Assigned (was: Untriaged)
Michael, please adjust priority or un-own as you see fit.
Well, this is definitely a bug, but probably not the one you intended to point out ;)

The android.intent.extra.VR_LAUNCH extra is only for deep linked apps, so it shouldn't let you enter VR at all. I think the problem here is we're not correctly handling 2D intents explicitly targeted at the VR Launcher. I'll have to investigate.

If you want to test out VR intents, the correct thing to do is send a normal 2D intent, but add the Daydream category to the intent. (com.google.intent.category.DAYDREAM or com.google.intent.category.CARDBOARD)
Summary: VR: Explicit 2D intents targeting VR launcher with deep-link extra try to enter VR (was: [Intents] cold-starting VR browsing via an intent to open a standard 2D page fails)
Note that Michael and I are chatting about #2 and will update the manual test plan accordingly. 
Cc: ymalik@chromium.org
I'm going to dig into this some more, but it looks like your intent isn't the problem.
It looks like on Dev, the intents are going to CTA instead of CCT...
Labels: -M-67 M-66
Labels: -M-66 M-67
False alarm, Dev is fine. I had an unsigned dev build on.
On current Dev build I don't see the bug in the original post at all. With the VR Intents flag off I get taken to DD home. With the VR Intents flag on I enter VR as expected.
FYI, this will be fixed with https://bugs.chromium.org/p/chromium/issues/detail?id=821538

--ez android.intent.extra.VR_LAUNCH will no longer be required on VR intents (it'll be completely ignored, actually).

Any explicit intents to VrMainActivity will be treated as VR intents, and implicit intents (that don't specify the target activity) should resolve to VrMainActivity as long as they specify the cardboard category.
Status: Fixed (was: Assigned)

Sign in to add a comment