VR: Explicit 2D intents targeting VR launcher with deep-link extra try to enter VR |
||||||
Issue descriptionChrome Version: 66.0.3356.0 OS: Android N Device: S8+ VrCore: 1.13.185188193 What steps will reproduce the problem? (1) enable the vr-launch-intents flag (2) close Chrome (3) Open any app, e.g. calculator (4) connect phone via adb (5) run the following command adb shell am start -a android.intent.action.VIEW -n "com.chrome.dev/org.chromium.chrome.browser.vr.VrMainActivity" --ez android.intent.extra.VR_LAUNCH true -d www.google.com What is the expected result? VR browsing experience launches (DON flow included) What happens instead? A failure message appears in VR browsing, then Chrome in 2D mode appears. See attached video.
,
Mar 6 2018
Well, this is definitely a bug, but probably not the one you intended to point out ;) The android.intent.extra.VR_LAUNCH extra is only for deep linked apps, so it shouldn't let you enter VR at all. I think the problem here is we're not correctly handling 2D intents explicitly targeted at the VR Launcher. I'll have to investigate. If you want to test out VR intents, the correct thing to do is send a normal 2D intent, but add the Daydream category to the intent. (com.google.intent.category.DAYDREAM or com.google.intent.category.CARDBOARD)
,
Mar 6 2018
,
Mar 7 2018
Note that Michael and I are chatting about #2 and will update the manual test plan accordingly.
,
Mar 8 2018
I'm going to dig into this some more, but it looks like your intent isn't the problem.
,
Mar 8 2018
It looks like on Dev, the intents are going to CTA instead of CCT...
,
Mar 8 2018
,
Mar 8 2018
False alarm, Dev is fine. I had an unsigned dev build on.
,
Mar 8 2018
On current Dev build I don't see the bug in the original post at all. With the VR Intents flag off I get taken to DD home. With the VR Intents flag on I enter VR as expected.
,
Mar 22 2018
FYI, this will be fixed with https://bugs.chromium.org/p/chromium/issues/detail?id=821538 --ez android.intent.extra.VR_LAUNCH will no longer be required on VR intents (it'll be completely ignored, actually). Any explicit intents to VrMainActivity will be treated as VR intents, and implicit intents (that don't specify the target activity) should resolve to VrMainActivity as long as they specify the cardboard category.
,
Mar 27 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by cjgrant@chromium.org
, Mar 6 2018Owner: mthiesse@chromium.org
Status: Assigned (was: Untriaged)