New issue
Advanced search Search tips

Issue 817490 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility

Blocking:
issue 709824



Sign in to add a comment

Docked Magnifier: Hook up increase/decrease scale shortcuts.

Project Member Reported by afakhry@chromium.org, Feb 28 2018

Issue description

For the Fullscreen magnifier, we have the two shortcuts Ctrl+Alt+BrightnessDown/BrightnessUp to decrease/increase the scale value. It is required that we make those same shortcuts work with the Docked Magnifier when it's enabled.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba41da593b76dd6803f2d49256b872a2067e66d9

commit ba41da593b76dd6803f2d49256b872a2067e66d9
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Thu Mar 01 18:10:40 2018

Docked Magnifier: Hook up zoom in/out shortcuts

This CL makes the existing shortcuts affect whatever
magnifier is currently enabled. This was also an
opportunity to unify some scale related code.

BUG= 817490 
TEST=Added test coverage

Change-Id: I366ee56629d09ae22c725b034bfc410077fe52ab
Reviewed-on: https://chromium-review.googlesource.com/942052
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540208}
[modify] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/BUILD.gn
[modify] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/accelerators/accelerator_table.cc
[modify] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/accelerators/accelerator_table.h
[modify] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/magnifier/docked_magnifier_controller.cc
[modify] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/magnifier/docked_magnifier_controller.h
[modify] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/magnifier/magnification_controller.h
[modify] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/magnifier/magnification_controller_unittest.cc
[add] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/magnifier/magnifier_scale_utils.cc
[add] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/magnifier/magnifier_scale_utils.h
[add] https://crrev.com/ba41da593b76dd6803f2d49256b872a2067e66d9/ash/magnifier/magnifier_scale_utils_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment