New issue
Advanced search Search tips

Issue 817475 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK failure when dragging inside a folder with 2 items

Project Member Reported by newcomer@chromium.org, Feb 28 2018

Issue description

ToT.

In a folder with 2 icons.
Drag the second icon to the first position.

DCHECK will fail because the index is invalid.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/905ed37fda1270620613d34011aa1c340006d0b5

commit 905ed37fda1270620613d34011aa1c340006d0b5
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Mar 01 17:24:15 2018

cros:Fix DCHECK failure when dragging in a folder

In the new applist folders we re-use various components.

In AppsGridView we had a bool that was used to determine if we
should show suggested apps, but the bool did not check to see if
the AppsGridView was being used inside a folder.

This was causing a DCHECK failure because row was being computed as -1
when there were 2 items in a folder and a folder item is dragged to the
first position.

Bug:  817475 
Change-Id: Ie50583e947f9b9b6ba37a536ae327f935531d35e
Reviewed-on: https://chromium-review.googlesource.com/941546
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540196}
[modify] https://crrev.com/905ed37fda1270620613d34011aa1c340006d0b5/ui/app_list/views/apps_grid_view.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment